Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2946463002: Convert multi-profile user behavior string to enum and send it to UI. (Closed)

Created:
3 years, 6 months ago by xiaoyinh(OOO Sep 11-29)
Modified:
3 years, 6 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert multi-profile user behavior string to enum and send it to UI. Multi-profile user behavior is a string value saved in kMultiProfileUserBehavior prefs which is mapped with a user policy ChromeOsMultiProfileUserBehavior. This CL converts the string value to a enum and send it to user pod UI. The kMultiProfileUserBehavior prefs and the cached value in the local state is not changed(still string value). BUG=729687 Review-Url: https://codereview.chromium.org/2946463002 Cr-Commit-Position: refs/heads/master@{#480141} Committed: https://chromium.googlesource.com/chromium/src/+/10e509ce2fc699d0e26a98bb05446d51d62e4473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -7 lines) Patch
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller.h View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M ui/login/account_picker/md_user_pod_row.js View 2 chunks +15 lines, -3 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
xiaoyinh(OOO Sep 11-29)
Hi xiyuan@, jdufault@, please take a look. Thanks!
3 years, 6 months ago (2017-06-16 18:50:49 UTC) #8
xiyuan
lgtm
3 years, 6 months ago (2017-06-16 19:01:46 UTC) #10
jdufault
lgtm
3 years, 6 months ago (2017-06-16 20:02:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946463002/1
3 years, 6 months ago (2017-06-16 20:05:01 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 20:10:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10e509ce2fc699d0e26a98bb0544...

Powered by Google App Engine
This is Rietveld 408576698