Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2946453002: Extensions: cover content with header on small monitors (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Extensions: cover content with header on small monitors R=rdevlin.cronin@chromium.org BUG=734013 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2946453002 Cr-Commit-Position: refs/heads/master@{#480189} Committed: https://chromium.googlesource.com/chromium/src/+/9302b5ae92a433159b8ab89ae77d08a4f253b72f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/resources/extensions/extensions.css View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Dan Beam
this is kinda sorta ninja patch-y just ship md extensions plz kthx
3 years, 6 months ago (2017-06-16 17:45:08 UTC) #2
Devlin
ninja patch is best patch. lgtm, thanks for the fix!
3 years, 6 months ago (2017-06-16 17:54:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946453002/1
3 years, 6 months ago (2017-06-16 17:55:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/481166)
3 years, 6 months ago (2017-06-16 20:53:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946453002/1
3 years, 6 months ago (2017-06-16 21:09:16 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 22:05:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9302b5ae92a433159b8ab89ae77d...

Powered by Google App Engine
This is Rietveld 408576698