Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: milo/api/config/project.proto

Issue 2946443003: Milo: (Breaking proto change) Update console definition (Closed)
Patch Set: ImportFix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | milo/api/config/project.pb.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/api/config/project.proto
diff --git a/milo/api/config/project.proto b/milo/api/config/project.proto
index 21014c46831d6da2f66d0ee84d3b10e5061c5e42..163feff35a34ce2a784aa1dffaeb84b7ba7b5e2a 100644
--- a/milo/api/config/project.proto
+++ b/milo/api/config/project.proto
@@ -11,16 +11,8 @@ message Project {
// ID is the identifier for the project, if different from its repository name.
string ID = 1;
- // Readers is the list of gaia users or Chrome-infra-auth groups allowed to view
- // the project.
- repeated string Readers = 2;
-
- // Writers is the list of gaia users or Chrome-infra-auth groups allowed to
- // perform actions on parts of the project.
- repeated string Writers = 3;
-
// Consoles is a list of consoles to define under /console/
- repeated Console Consoles = 4;
+ repeated Console Consoles = 2;
}
// Console is a waterfall definition consisting of one or more builders.
@@ -33,29 +25,34 @@ message Console {
// displayed in the title.
string Name = 2;
- // RepoURL is the name of the git repository to display as the rows of the console.
+ // RepoURL is the URL of the git repository to display as the rows of the console.
string RepoURL = 3;
// Branch is the branch to pull commits from when displaying the console.
string Branch = 4;
+ // ManifestName is the name of the manifest the waterfall looks at.
+ // By convention, Manifest Names can be:
+ // * UNPATCHED - For non patched builds, such as continuous builds
+ // * PATCHED - For patched builds, such as those on try jobs
+ string ManifestName = 5;
+
// Builders is a list of builder configurations to display as the columns of the console.
- repeated Builder Builders = 5;
+ repeated Builder Builders = 6;
}
// A builder is a reference to a Milo builder.
message Builder {
- // Module is the name of the Milo module this builder is in reference to.
- string Module = 1;
-
- // Name is the identifier to find the builder within the module.
- string Name = 2;
+ // Name is the identifier to find the builder, which includes the module.
+ // Buildbot builds would be like "buildbot/chromium.linux/Linux Tests"
+ // Buildbucket builds would be like "buildbucket/luci.chromium.try/linux_chromium_rel_ng"
+ string Name = 1;
// Category describes the hierarchy of the builder on the header of the
// console as a "|" delimited list. Neighboring builders with common ancestors
// will be have their headers merged.
- string Category = 3;
+ string Category = 2;
// ShortName is the 1-3 character abbreviation of the builder.
- string ShortName = 4;
+ string ShortName = 3;
}
« no previous file with comments | « no previous file | milo/api/config/project.pb.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698