Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: milo/api/config/project.pb.go

Issue 2946443003: Milo: (Breaking proto change) Update console definition (Closed)
Patch Set: ImportFix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/api/config/project.proto ('k') | milo/api/resp/console.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/api/config/project.pb.go
diff --git a/milo/api/config/project.pb.go b/milo/api/config/project.pb.go
index 9a931611ab5a7a81a22cbe5e7f2a2fd23a4623d6..4498728ae96ba6a911c63e611e880fb01d264361 100644
--- a/milo/api/config/project.pb.go
+++ b/milo/api/config/project.pb.go
@@ -35,14 +35,8 @@ const _ = proto.ProtoPackageIsVersion2 // please upgrade the proto package
type Project struct {
// ID is the identifier for the project, if different from its repository name.
ID string `protobuf:"bytes,1,opt,name=ID" json:"ID,omitempty"`
- // Readers is the list of gaia users or Chrome-infra-auth groups allowed to view
- // the project.
- Readers []string `protobuf:"bytes,2,rep,name=Readers" json:"Readers,omitempty"`
- // Writers is the list of gaia users or Chrome-infra-auth groups allowed to
- // perform actions on parts of the project.
- Writers []string `protobuf:"bytes,3,rep,name=Writers" json:"Writers,omitempty"`
// Consoles is a list of consoles to define under /console/
- Consoles []*Console `protobuf:"bytes,4,rep,name=Consoles" json:"Consoles,omitempty"`
+ Consoles []*Console `protobuf:"bytes,2,rep,name=Consoles" json:"Consoles,omitempty"`
}
func (m *Project) Reset() { *m = Project{} }
@@ -57,20 +51,6 @@ func (m *Project) GetID() string {
return ""
}
-func (m *Project) GetReaders() []string {
- if m != nil {
- return m.Readers
- }
- return nil
-}
-
-func (m *Project) GetWriters() []string {
- if m != nil {
- return m.Writers
- }
- return nil
-}
-
func (m *Project) GetConsoles() []*Console {
if m != nil {
return m.Consoles
@@ -86,12 +66,17 @@ type Console struct {
// Name is the longform name of the waterfall, and will be used to be
// displayed in the title.
Name string `protobuf:"bytes,2,opt,name=Name" json:"Name,omitempty"`
- // RepoURL is the name of the git repository to display as the rows of the console.
+ // RepoURL is the URL of the git repository to display as the rows of the console.
RepoURL string `protobuf:"bytes,3,opt,name=RepoURL" json:"RepoURL,omitempty"`
// Branch is the branch to pull commits from when displaying the console.
Branch string `protobuf:"bytes,4,opt,name=Branch" json:"Branch,omitempty"`
+ // ManifestName is the name of the manifest the waterfall looks at.
+ // By convention, Manifest Names can be:
+ // * UNPATCHED - For non patched builds, such as continuous builds
+ // * PATCHED - For patched builds, such as those on try jobs
+ ManifestName string `protobuf:"bytes,5,opt,name=ManifestName" json:"ManifestName,omitempty"`
// Builders is a list of builder configurations to display as the columns of the console.
- Builders []*Builder `protobuf:"bytes,5,rep,name=Builders" json:"Builders,omitempty"`
+ Builders []*Builder `protobuf:"bytes,6,rep,name=Builders" json:"Builders,omitempty"`
}
func (m *Console) Reset() { *m = Console{} }
@@ -127,6 +112,13 @@ func (m *Console) GetBranch() string {
return ""
}
+func (m *Console) GetManifestName() string {
+ if m != nil {
+ return m.ManifestName
+ }
+ return ""
+}
+
func (m *Console) GetBuilders() []*Builder {
if m != nil {
return m.Builders
@@ -136,16 +128,16 @@ func (m *Console) GetBuilders() []*Builder {
// A builder is a reference to a Milo builder.
type Builder struct {
- // Module is the name of the Milo module this builder is in reference to.
- Module string `protobuf:"bytes,1,opt,name=Module" json:"Module,omitempty"`
- // Name is the identifier to find the builder within the module.
- Name string `protobuf:"bytes,2,opt,name=Name" json:"Name,omitempty"`
+ // Name is the identifier to find the builder, which includes the module.
+ // Buildbot builds would be like "buildbot/chromium.linux/Linux Tests"
+ // Buildbucket builds would be like "buildbucket/luci.chromium.try/linux_chromium_rel_ng"
+ Name string `protobuf:"bytes,1,opt,name=Name" json:"Name,omitempty"`
// Category describes the hierarchy of the builder on the header of the
// console as a "|" delimited list. Neighboring builders with common ancestors
// will be have their headers merged.
- Category string `protobuf:"bytes,3,opt,name=Category" json:"Category,omitempty"`
+ Category string `protobuf:"bytes,2,opt,name=Category" json:"Category,omitempty"`
// ShortName is the 1-3 character abbreviation of the builder.
- ShortName string `protobuf:"bytes,4,opt,name=ShortName" json:"ShortName,omitempty"`
+ ShortName string `protobuf:"bytes,3,opt,name=ShortName" json:"ShortName,omitempty"`
}
func (m *Builder) Reset() { *m = Builder{} }
@@ -153,13 +145,6 @@ func (m *Builder) String() string { return proto.CompactTextString(m)
func (*Builder) ProtoMessage() {}
func (*Builder) Descriptor() ([]byte, []int) { return fileDescriptor0, []int{2} }
-func (m *Builder) GetModule() string {
- if m != nil {
- return m.Module
- }
- return ""
-}
-
func (m *Builder) GetName() string {
if m != nil {
return m.Name
@@ -192,23 +177,22 @@ func init() {
}
var fileDescriptor0 = []byte{
- // 278 bytes of a gzipped FileDescriptorProto
- 0x1f, 0x8b, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0xff, 0x6c, 0x91, 0xcd, 0x4a, 0xf4, 0x30,
- 0x14, 0x86, 0xe9, 0xcf, 0xd7, 0x4e, 0xcf, 0x07, 0x0a, 0x59, 0x48, 0x10, 0x17, 0xa5, 0xab, 0x82,
- 0xd8, 0x82, 0xe2, 0x0d, 0xcc, 0xcc, 0x66, 0x40, 0x45, 0x22, 0xe2, 0xba, 0xd3, 0x89, 0x6d, 0x24,
- 0xed, 0x29, 0x69, 0xba, 0xd0, 0x6b, 0xf0, 0xa2, 0xa5, 0x49, 0xa6, 0x22, 0xba, 0x29, 0x79, 0xde,
- 0xf7, 0xb4, 0xe7, 0x29, 0x81, 0xdb, 0x46, 0xe8, 0x76, 0xda, 0x17, 0x35, 0x76, 0xa5, 0x9c, 0x6a,
- 0x61, 0x1e, 0x57, 0x0d, 0x96, 0x9d, 0x90, 0x58, 0x56, 0x83, 0x28, 0x6b, 0xec, 0x5f, 0x45, 0x53,
- 0x0e, 0x0a, 0xdf, 0x78, 0xad, 0x8b, 0x41, 0xa1, 0x46, 0x12, 0xd9, 0x34, 0xfb, 0x80, 0xf8, 0xd1,
- 0x16, 0xe4, 0x04, 0xfc, 0xdd, 0x96, 0x7a, 0xa9, 0x97, 0x27, 0xcc, 0xdf, 0x6d, 0x09, 0x85, 0x98,
- 0xf1, 0xea, 0xc0, 0xd5, 0x48, 0xfd, 0x34, 0xc8, 0x13, 0x76, 0xc4, 0xb9, 0x79, 0x51, 0x42, 0xcf,
- 0x4d, 0x60, 0x1b, 0x87, 0xe4, 0x12, 0x56, 0x1b, 0xec, 0x47, 0x94, 0x7c, 0xa4, 0x61, 0x1a, 0xe4,
- 0xff, 0xaf, 0x4f, 0x0b, 0xbb, 0xa9, 0x70, 0x39, 0x5b, 0x06, 0xb2, 0x4f, 0x0f, 0x62, 0x07, 0xbf,
- 0x96, 0x13, 0x08, 0x1f, 0xaa, 0x8e, 0x53, 0xdf, 0x24, 0xe6, 0x6c, 0x85, 0x06, 0x7c, 0x66, 0x77,
- 0x34, 0x30, 0xf1, 0x11, 0xc9, 0x19, 0x44, 0x6b, 0x55, 0xf5, 0x75, 0x4b, 0x43, 0x53, 0x38, 0x9a,
- 0x75, 0xd6, 0x93, 0x90, 0xe6, 0x1f, 0xfe, 0xfd, 0xd4, 0x71, 0x39, 0x5b, 0x06, 0x32, 0x84, 0xd8,
- 0x9d, 0xe7, 0xef, 0xdd, 0xe3, 0x61, 0x92, 0xdc, 0x19, 0x39, 0xfa, 0xd3, 0xea, 0x1c, 0x56, 0x9b,
- 0x4a, 0xf3, 0x06, 0xd5, 0xbb, 0xd3, 0x5a, 0x98, 0x5c, 0x40, 0xf2, 0xd4, 0xa2, 0xd2, 0xe6, 0x25,
- 0xab, 0xf6, 0x1d, 0xec, 0x23, 0x73, 0x15, 0x37, 0x5f, 0x01, 0x00, 0x00, 0xff, 0xff, 0xd4, 0xda,
- 0x09, 0xda, 0xc3, 0x01, 0x00, 0x00,
+ // 263 bytes of a gzipped FileDescriptorProto
+ 0x1f, 0x8b, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0xff, 0x64, 0x90, 0xd1, 0x4a, 0xc3, 0x30,
+ 0x14, 0x86, 0x69, 0x37, 0xdb, 0xed, 0x28, 0x0a, 0xb9, 0x90, 0x20, 0x5e, 0x8c, 0x5e, 0x0d, 0xc4,
+ 0x06, 0x14, 0x5f, 0x60, 0x1b, 0xc2, 0x40, 0x45, 0x22, 0xe2, 0x75, 0x16, 0xb3, 0x36, 0xd2, 0xf6,
+ 0x94, 0x34, 0xbd, 0xf0, 0xad, 0x7c, 0x44, 0x31, 0x89, 0xd5, 0xb2, 0x9b, 0x72, 0xfe, 0xef, 0x3f,
+ 0x3d, 0x7c, 0x04, 0xee, 0x0a, 0x6d, 0xcb, 0x7e, 0x97, 0x4b, 0xac, 0x59, 0xd5, 0x4b, 0xed, 0x3e,
+ 0xd7, 0x05, 0xb2, 0x5a, 0x57, 0xc8, 0x44, 0xab, 0x99, 0xc4, 0x66, 0xaf, 0x0b, 0xd6, 0x1a, 0xfc,
+ 0x50, 0xd2, 0xe6, 0xad, 0x41, 0x8b, 0x24, 0xf1, 0x34, 0xbb, 0x87, 0xf4, 0xd9, 0x17, 0xe4, 0x14,
+ 0xe2, 0xed, 0x86, 0x46, 0x8b, 0x68, 0x39, 0xe7, 0xf1, 0x76, 0x43, 0xae, 0x60, 0xb6, 0xc6, 0xa6,
+ 0xc3, 0x4a, 0x75, 0x34, 0x5e, 0x4c, 0x96, 0xc7, 0x37, 0x67, 0xb9, 0xff, 0x2b, 0x0f, 0x9c, 0x0f,
+ 0x0b, 0xd9, 0x57, 0x04, 0x69, 0x08, 0x07, 0x87, 0x08, 0x4c, 0x9f, 0x44, 0xad, 0x68, 0xec, 0x88,
+ 0x9b, 0x09, 0x85, 0x94, 0xab, 0x16, 0x5f, 0xf9, 0x03, 0x9d, 0x38, 0xfc, 0x1b, 0xc9, 0x39, 0x24,
+ 0x2b, 0x23, 0x1a, 0x59, 0xd2, 0xa9, 0x2b, 0x42, 0x22, 0x19, 0x9c, 0x3c, 0x8a, 0x46, 0xef, 0x55,
+ 0x67, 0xdd, 0xb5, 0x23, 0xd7, 0x8e, 0xd8, 0x8f, 0xf2, 0xaa, 0xd7, 0xd5, 0xbb, 0x32, 0x1d, 0x4d,
+ 0xc6, 0xca, 0x81, 0xf3, 0x61, 0x21, 0x7b, 0x83, 0x34, 0xcc, 0x83, 0x61, 0xf4, 0xcf, 0xf0, 0x02,
+ 0x66, 0x6b, 0x61, 0x55, 0x81, 0xe6, 0x33, 0x98, 0x0f, 0x99, 0x5c, 0xc2, 0xfc, 0xa5, 0x44, 0xe3,
+ 0x45, 0xbc, 0xff, 0x1f, 0xd8, 0x25, 0xee, 0x89, 0x6f, 0xbf, 0x03, 0x00, 0x00, 0xff, 0xff, 0xfb,
+ 0x59, 0x08, 0x73, 0x9b, 0x01, 0x00, 0x00,
}
« no previous file with comments | « milo/api/config/project.proto ('k') | milo/api/resp/console.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698