Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2946433002: Fix a regression from i18n-* -> $i18n{} migration (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 6 months ago
Reviewers:
edwardjung, dpapad
CC:
chromium-reviews, dschuyler, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a regression from i18n-* -> $i18n{} migration R=edwardjung@chromium.org BUG=677338 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2946433002 Cr-Commit-Position: refs/heads/master@{#480119} Committed: https://chromium.googlesource.com/chromium/src/+/dbefe70c77d6504edfc6056905d0ff318006ee39

Patch Set 1 : one more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/device_log_ui/device_log_ui.html View 1 chunk +1 line, -1 line 0 comments Download
M components/flags_ui/resources/apple_flags.html View 1 chunk +1 line, -1 line 0 comments Download
M components/neterror/resources/neterror.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Dan Beam
3 years, 6 months ago (2017-06-16 17:07:54 UTC) #2
edwardjung
lgtm
3 years, 6 months ago (2017-06-16 17:09:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946433002/20001
3 years, 6 months ago (2017-06-16 17:22:40 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-16 17:22:42 UTC) #11
dpapad
lgtm
3 years, 6 months ago (2017-06-16 17:58:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946433002/20001
3 years, 6 months ago (2017-06-16 18:03:45 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 19:19:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dbefe70c77d6504edfc6056905d0...

Powered by Google App Engine
This is Rietveld 408576698