Added timeout parameter to RawSocket and Socket connect, which allows for the specification of a ma…

Added timeout parameter to RawSocket and Socket connect, which allows for the specification of a maximum time to wait for a valid connection to be established.

fixes #19120

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/86fdbde70a0d22cdf03612ce2d5a3f38ded71634

[bkonyi, 2017-06-21 19:31:04]

bkonyi@google.com changed reviewers:
+ zra@google.com

[zra, 2017-06-21 20:22:33]

Description was changed from

==========
Added timeout parameter to RawSocket and Socket connect, which allows for the
specification of a maximum time to wait for a valid connection to be
established.

BUG=
==========

to

==========
Added timeout parameter to RawSocket and Socket connect, which allows for the
specification of a maximum time to wait for a valid connection to be
established.

fixes #19120
==========

[zra, 2017-06-21 20:32:32]

https://codereview.chromium.org/2946333002/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/2946333002/diff/1/runtime/bin/socket_patch.da...
runtime/bin/socket_patch.dart:440: completer.completeError(error);
It shouldn't be necessary, but I would be a little extra paranoid, and cancel
the timeoutTimer here.

https://codereview.chromium.org/2946333002/diff/1/runtime/bin/socket_patch.da...
runtime/bin/socket_patch.dart:485: timer.cancel();
And here.

https://codereview.chromium.org/2946333002/diff/1/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/2946333002/diff/1/sdk/lib/io/socket.dart#newc...
sdk/lib/io/socket.dart:431: * [timeout].
Say what happens when there is a timeout.

https://codereview.chromium.org/2946333002/diff/1/sdk/lib/io/socket.dart#newc...
sdk/lib/io/socket.dart:532: * The argument [timeout] is used to specify the
maximum allowed time to wait
ditto

https://codereview.chromium.org/2946333002/diff/1/tests/standalone/io/socket_...
File tests/standalone/io/socket_test.dart (right):

https://codereview.chromium.org/2946333002/diff/1/tests/standalone/io/socket_...
tests/standalone/io/socket_test.dart:202: Socket.connect("8.8.8.7", 80, timeout:
timeout).then((socket) {
asyncStart();

https://codereview.chromium.org/2946333002/diff/1/tests/standalone/io/socket_...
tests/standalone/io/socket_test.dart:205: if (!(e is SocketException)) {
Expect.isTrue(e is SocketException)

https://codereview.chromium.org/2946333002/diff/1/tests/standalone/io/socket_...
tests/standalone/io/socket_test.dart:207: }
asyncEnd();

[bkonyi, 2017-06-21 21:20:05]

https://codereview.chromium.org/2946333002/diff/1/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/2946333002/diff/1/sdk/lib/io/socket.dart#newc...
sdk/lib/io/socket.dart:431: * [timeout].
On 2017/06/21 20:32:31, zra wrote:
> Say what happens when there is a timeout.

Done.

https://codereview.chromium.org/2946333002/diff/1/sdk/lib/io/socket.dart#newc...
sdk/lib/io/socket.dart:532: * The argument [timeout] is used to specify the
maximum allowed time to wait
On 2017/06/21 20:32:32, zra wrote:
> ditto

Done.

https://codereview.chromium.org/2946333002/diff/1/tests/standalone/io/socket_...
File tests/standalone/io/socket_test.dart (right):

https://codereview.chromium.org/2946333002/diff/1/tests/standalone/io/socket_...
tests/standalone/io/socket_test.dart:202: Socket.connect("8.8.8.7", 80, timeout:
timeout).then((socket) {
On 2017/06/21 20:32:32, zra wrote:
> asyncStart();

Done.

https://codereview.chromium.org/2946333002/diff/1/tests/standalone/io/socket_...
tests/standalone/io/socket_test.dart:205: if (!(e is SocketException)) {
On 2017/06/21 20:32:32, zra wrote:
> Expect.isTrue(e is SocketException)

Done.

https://codereview.chromium.org/2946333002/diff/1/tests/standalone/io/socket_...
tests/standalone/io/socket_test.dart:207: }
On 2017/06/21 20:32:32, zra wrote:
> asyncEnd();

Done.

[zra, 2017-06-21 21:24:29]

lgtm after also updating the CHANGELOG with a short message.

[bkonyi, 2017-06-21 21:32:00]

Description was changed from

==========
Added timeout parameter to RawSocket and Socket connect, which allows for the
specification of a maximum time to wait for a valid connection to be
established.

fixes #19120
==========

to

==========
Added timeout parameter to RawSocket and Socket connect, which allows for the
specification of a maximum time to wait for a valid connection to be
established.

fixes #19120

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/86fdbde70a0d22cdf03612ce2d5a3f38ded71634
==========

[bkonyi, 2017-06-21 21:32:01]

Committed patchset #3 (id:40001) manually as
86fdbde70a0d22cdf03612ce2d5a3f38ded71634 (presubmit successful).