Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1856)

Unified Diff: sdk/lib/_internal/js_runtime/lib/io_patch.dart

Issue 2946333002: Added timeout parameter to RawSocket and Socket connect, which allows for the specification of a ma… (Closed)
Patch Set: Updated CHANGELOG.md Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/socket_patch.dart ('k') | sdk/lib/io/socket.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/js_runtime/lib/io_patch.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/io_patch.dart b/sdk/lib/_internal/js_runtime/lib/io_patch.dart
index 59aa7fff52f5b3f87b5c9250dcef697a5fec4fe3..2dabd3123d6ea8ce7f39c9bdce03fca95ca626df 100644
--- a/sdk/lib/_internal/js_runtime/lib/io_patch.dart
+++ b/sdk/lib/_internal/js_runtime/lib/io_patch.dart
@@ -419,7 +419,8 @@ class ServerSocket {
@patch
class RawSocket {
@patch
- static Future<RawSocket> connect(host, int port, {sourceAddress}) {
+ static Future<RawSocket> connect(host, int port,
+ {sourceAddress, Duration timeout}) {
throw new UnsupportedError("RawSocket constructor");
}
}
@@ -427,7 +428,8 @@ class RawSocket {
@patch
class Socket {
@patch
- static Future<Socket> connect(host, int port, {sourceAddress}) {
+ static Future<Socket> connect(host, int port,
+ {sourceAddress, Duration timeout}) {
throw new UnsupportedError("Socket constructor");
}
}
« no previous file with comments | « runtime/bin/socket_patch.dart ('k') | sdk/lib/io/socket.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698