Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2946303002: [wasm] Remove double check for --experimental-wasm-simd flag (Closed)

Created:
3 years, 6 months ago by gdeepti
Modified:
3 years, 6 months ago
Reviewers:
bbudge
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove double check for --experimental-wasm-simd flag This was left over from the previous CL to change S128LoadMem/S128StoreMem to use prefixed opcodes. Decoding prefixed opcodes already checks for the prototype flag. BUG=V8:6020 R=bbudge@chromium.org Review-Url: https://codereview.chromium.org/2946303002 Cr-Commit-Position: refs/heads/master@{#46108} Committed: https://chromium.googlesource.com/v8/v8/+/9f33191a041a3d7908d80db711c9a734d4440e2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/wasm/function-body-decoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
gdeepti
3 years, 6 months ago (2017-06-21 19:28:45 UTC) #5
gdeepti
3 years, 6 months ago (2017-06-21 19:28:47 UTC) #6
bbudge
lgtm
3 years, 6 months ago (2017-06-21 20:16:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946303002/1
3 years, 6 months ago (2017-06-21 22:03:27 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 22:04:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9f33191a041a3d7908d80db711c9a734d44...

Powered by Google App Engine
This is Rietveld 408576698