Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2946183002: Mac: Don't replace the alpha on the detached toolbar separator color. (Closed)

Created:
3 years, 6 months ago by tapted
Modified:
3 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Don't replace the alpha on the detached toolbar separator color. The Cocoa browser used to clobber the theme's alpha with 50%. But since r480275, theme_service.cc makes appropriate adjustments to the color instead. BUG=734476 Review-Url: https://codereview.chromium.org/2946183002 Cr-Commit-Position: refs/heads/master@{#481375} Committed: https://chromium.googlesource.com/chromium/src/+/36d91d332d9c8d867cd564f958e7406b7ef893c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
tapted
3 years, 6 months ago (2017-06-21 01:17:30 UTC) #5
Evan Stade
awesome, thanks! lgtm
3 years, 6 months ago (2017-06-21 15:43:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946183002/1
3 years, 6 months ago (2017-06-22 00:25:38 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 00:34:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36d91d332d9c8d867cd564f958e7...

Powered by Google App Engine
This is Rietveld 408576698