Remove legacy popular sites cache cleaning

Remove legacy popular sites cache cleaning

The cache cleaner is not necessary for recent Chromium versions anymore.
By removing this now, we also clean the deprecated call for a blocking
worker pool.

BUG=683890, 667892
Review-Url: https://codereview.chromium.org/2946143002
Cr-Commit-Position: refs/heads/master@{#481997}
Committed: https://chromium.googlesource.com/chromium/src/+/b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7

[fhorschig, 2017-06-20 23:04:37]

The CQ bit was checked by fhorschig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 23:04:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fhorschig, 2017-06-20 23:06:01]

fhorschig@chromium.org changed reviewers:
+ mastiz@chromium.org

[fhorschig, 2017-06-20 23:06:02]

Hi Mikel,
would you please take a look at the removal of the legacy cache cleaning and
removal of call to |GetBlockingWorkerPool|?

[commit-bot: I haz the power, 2017-06-20 23:24:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 23:24:28]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[fhorschig, 2017-06-20 23:29:23]

The CQ bit was checked by fhorschig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 23:29:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 23:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 23:43:41]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[mastiz, 2017-06-21 04:44:22]

LGTM, thanks!!

https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/po...
File components/ntp_tiles/popular_sites_impl.h (right):

https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/po...
components/ntp_tiles/popular_sites_impl.h:13: #include "base/files/file_path.h"
Nit: is this needed?

https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/po...
File components/ntp_tiles/popular_sites_impl_unittest.cc (right):

https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/po...
components/ntp_tiles/popular_sites_impl_unittest.cc:15: #include
"base/files/important_file_writer.h"
Same for the two above.

[fhorschig, 2017-06-23 18:09:51]

The CQ bit was checked by fhorschig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 18:10:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fhorschig, 2017-06-23 18:11:23]

https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/po...
File components/ntp_tiles/popular_sites_impl.h (right):

https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/po...
components/ntp_tiles/popular_sites_impl.h:13: #include "base/files/file_path.h"
On 2017/06/21 04:44:22, mastiz wrote:
> Nit: is this needed?

Gone.

https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/po...
File components/ntp_tiles/popular_sites_impl_unittest.cc (right):

https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/po...
components/ntp_tiles/popular_sites_impl_unittest.cc:15: #include
"base/files/important_file_writer.h"
On 2017/06/21 04:44:22, mastiz wrote:
> Same for the two above.

Gone.

[commit-bot: I haz the power, 2017-06-23 19:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 19:16:35]

Dry run: This issue passed the CQ dry run.

[fhorschig, 2017-06-23 19:58:03]

The CQ bit was checked by fhorschig@chromium.org

[fhorschig, 2017-06-23 19:58:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mastiz@chromium.org
Link to the patchset: https://codereview.chromium.org/2946143002/#ps40001
(title: "Remove unused imports")

[commit-bot: I haz the power, 2017-06-23 19:58:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 20:03:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498247883596470,
"parent_rev": "894e746f09827b773d8006792861ee3e3abab721", "commit_rev":
"b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7"}

[commit-bot: I haz the power, 2017-06-23 20:03:24]

Description was changed from

==========
Remove legacy popular sites cache cleaning

The cache cleaner is not necessary for recent Chromium versions anymore.
By removing this now, we also clean the deprecated call for a blocking
worker pool.

BUG=683890, 667892
==========

to

==========
Remove legacy popular sites cache cleaning

The cache cleaner is not necessary for recent Chromium versions anymore.
By removing this now, we also clean the deprecated call for a blocking
worker pool.

BUG=683890, 667892

Review-Url: https://codereview.chromium.org/2946143002
Cr-Commit-Position: refs/heads/master@{#481997}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8b9c6efcf9a97db1177fe3cdd3b...
==========

[commit-bot: I haz the power, 2017-06-23 20:03:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b8b9c6efcf9a97db1177fe3cdd3b...