Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2946143002: Remove legacy popular sites cache cleaning (Closed)

Created:
3 years, 6 months ago by fhorschig
Modified:
3 years, 6 months ago
Reviewers:
mastiz
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove legacy popular sites cache cleaning The cache cleaner is not necessary for recent Chromium versions anymore. By removing this now, we also clean the deprecated call for a blocking worker pool. BUG=683890, 667892 Review-Url: https://codereview.chromium.org/2946143002 Cr-Commit-Position: refs/heads/master@{#481997} Committed: https://chromium.googlesource.com/chromium/src/+/b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7

Patch Set 1 #

Patch Set 2 : Fix factory on iOS #

Total comments: 4

Patch Set 3 : Remove unused imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -78 lines) Patch
M chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M components/ntp_tiles/most_visited_sites_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M components/ntp_tiles/popular_sites_impl.h View 1 2 4 chunks +0 lines, -6 lines 0 comments Download
M components/ntp_tiles/popular_sites_impl.cc View 1 2 3 chunks +2 lines, -23 lines 0 comments Download
M components/ntp_tiles/popular_sites_impl_unittest.cc View 1 2 5 chunks +2 lines, -28 lines 0 comments Download
M ios/chrome/browser/ntp_tiles/ios_popular_sites_factory.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
fhorschig
Hi Mikel, would you please take a look at the removal of the legacy cache ...
3 years, 6 months ago (2017-06-20 23:06:02 UTC) #4
mastiz
LGTM, thanks!! https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/popular_sites_impl.h File components/ntp_tiles/popular_sites_impl.h (right): https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/popular_sites_impl.h#newcode13 components/ntp_tiles/popular_sites_impl.h:13: #include "base/files/file_path.h" Nit: is this needed? https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/popular_sites_impl_unittest.cc ...
3 years, 6 months ago (2017-06-21 04:44:22 UTC) #11
fhorschig
https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/popular_sites_impl.h File components/ntp_tiles/popular_sites_impl.h (right): https://codereview.chromium.org/2946143002/diff/20001/components/ntp_tiles/popular_sites_impl.h#newcode13 components/ntp_tiles/popular_sites_impl.h:13: #include "base/files/file_path.h" On 2017/06/21 04:44:22, mastiz wrote: > Nit: ...
3 years, 6 months ago (2017-06-23 18:11:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946143002/40001
3 years, 6 months ago (2017-06-23 19:58:28 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 20:03:27 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b8b9c6efcf9a97db1177fe3cdd3b...

Powered by Google App Engine
This is Rietveld 408576698