Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: content/public/browser/content_browser_client.cc

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)
Patch Set: Use FOR_EACH_TDI_MODE(V) macro. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.cc
diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
index 529f49fa7ff5469f6a1b4a0858b5de96a5ee8a2e..66f1c4a694c1aca8ba5eb2f53954011e9ac81f0e 100644
--- a/content/public/browser/content_browser_client.cc
+++ b/content/public/browser/content_browser_client.cc
@@ -91,10 +91,10 @@ bool ContentBrowserClient::ShouldAllowOpenURL(SiteInstance* site_instance,
return true;
}
-bool ContentBrowserClient::
- ShouldFrameShareParentSiteInstanceDespiteTopDocumentIsolation(
- const GURL& url,
- SiteInstance* parent_site_instance) {
+bool ContentBrowserClient::ShouldIsolateFrameFromMainContent(
+ RenderFrameHost* frame,
+ const GURL& dest_url,
+ SiteInstance* main_frame_site_instance) {
return false;
Charlie Reis 2017/06/30 23:28:46 Shouldn't this be true? Otherwise it seems like e
Łukasz Anforowicz 2017/07/01 00:10:53 Makes sense - I wasn't quite sure what should be r
}

Powered by Google App Engine
This is Rietveld 408576698