Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode.

content/public/browser/content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/content_browser_client.h"
 
 #include <utility>
 
 #include "base/files/file_path.h"
 #include "base/guid.h"
@@ skipping 73 matching lines @@
 bool ContentBrowserClient::CanCommitURL(RenderProcessHost* process_host,
                                         const GURL& site_url) {
   return true;
 }
 
 bool ContentBrowserClient::ShouldAllowOpenURL(SiteInstance* site_instance,
                                               const GURL& url) {
   return true;
 }
 
-bool ContentBrowserClient::
-    ShouldFrameShareParentSiteInstanceDespiteTopDocumentIsolation(
-        const GURL& url,
-        SiteInstance* parent_site_instance) {
+bool ContentBrowserClient::ShouldIsolateFrameFromMainContent(
+    RenderFrameHost* frame,
+    const GURL& dest_url,
+    SiteInstance* main_frame_site_instance) {
   return false;

[Charlie Reis, 2017/06/30 23:28:46]

Shouldn't this be true?  Otherwise it seems like embedders will get a
non-functioning TDI mode by default.

[Łukasz Anforowicz, 2017/07/01 00:10:53]

Makes sense - I wasn't quite sure what should be returned here.

Done.

 }
 
 bool ContentBrowserClient::IsSuitableHost(RenderProcessHost* process_host,
                                           const GURL& site_url) {
   return true;
 }
 
 bool ContentBrowserClient::MayReuseHost(RenderProcessHost* process_host) {
   return true;
 }
@@ skipping 351 matching lines @@
   return nullptr;
 }
 
 std::vector<std::unique_ptr<URLLoaderThrottle>>
 ContentBrowserClient::CreateURLLoaderThrottles(
     const base::Callback<WebContents*()>& wc_getter) {
   return std::vector<std::unique_ptr<URLLoaderThrottle>>();
 }
 
 }  // namespace content