Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)
Patch Set: Use FOR_EACH_TDI_MODE(V) macro. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.h
diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h
index a91a3b0a81e72c26bd6496c8083e366c48a6d3ed..537b3d0ec0404593c0384e12d2406bdb658e8448 100644
--- a/chrome/browser/chrome_content_browser_client.h
+++ b/chrome/browser/chrome_content_browser_client.h
@@ -111,9 +111,10 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
ui::PageTransition* transition,
bool* is_renderer_initiated,
content::Referrer* referrer) override;
- bool ShouldFrameShareParentSiteInstanceDespiteTopDocumentIsolation(
- const GURL& url,
- content::SiteInstance* parent_site_instance) override;
+ bool ShouldIsolateFrameFromMainContent(
+ content::RenderFrameHost* frame,
+ const GURL& dest_url,
+ content::SiteInstance* main_frame_site_instance) override;
bool IsSuitableHost(content::RenderProcessHost* process_host,
const GURL& site_url) override;
bool MayReuseHost(content::RenderProcessHost* process_host) override;

Powered by Google App Engine
This is Rietveld 408576698