Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: chrome/browser/about_flags.cc

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)
Patch Set: Use FOR_EACH_TDI_MODE(V) macro. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 805f11498046df3ef11cb5e4f63fab9fd4f63496..f0d6ec49a6e4342edab5bd74a95dafe8e168f7d9 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1078,6 +1078,20 @@ const FeatureEntry::FeatureVariation kOmniboxUIVerticalMarginVariations[] = {
{"14px vertical margin", kOmniboxUIVerticalMargin14px,
arraysize(kOmniboxUIVerticalMargin14px), nullptr}};
+#define DEFINE_TDI_MODE_FEATURE_PARAM(name, value, description) \
+ const FeatureEntry::FeatureParam kTopDocumentIsolationVariations_##name[] = \
+ {{features::kTopDocumentIsolationModeParam, #value}};
+FOR_EACH_TDI_MODE(DEFINE_TDI_MODE_FEATURE_PARAM)
+#undef DEFINE_TDI_MODE_FEATURE_PARAM
+
+const FeatureEntry::FeatureVariation kTopDocumentIsolationVariations[] = {
+#define DEFINE_TDI_MODE_VARIATION(name, value, description) \
+ {"(" #name " - " description ")", kTopDocumentIsolationVariations_##name, \
+ arraysize(kTopDocumentIsolationVariations_##name), nullptr},
+ FOR_EACH_TDI_MODE(DEFINE_TDI_MODE_VARIATION)
+#undef DEFINE_TDI_MODE_VARIATION
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the entry is the internal name.
@@ -1936,7 +1950,9 @@ const FeatureEntry kFeatureEntries[] = {
{"enable-top-document-isolation",
flag_descriptions::kTopDocumentIsolationName,
flag_descriptions::kTopDocumentIsolationDescription, kOsAll,
- FEATURE_VALUE_TYPE(features::kTopDocumentIsolation)},
+ FEATURE_WITH_PARAMS_VALUE_TYPE(features::kTopDocumentIsolation,
+ kTopDocumentIsolationVariations,
+ "TopDocumentIsolation")},
{"enable-use-zoom-for-dsf", flag_descriptions::kEnableUseZoomForDsfName,
flag_descriptions::kEnableUseZoomForDsfDescription, kOsAll,
MULTI_VALUE_TYPE(kEnableUseZoomForDSFChoices)},

Powered by Google App Engine
This is Rietveld 408576698