Chromium Code Reviews| Index: syzygy/integration_tests/integration_tests_dll.h |
| diff --git a/syzygy/integration_tests/integration_tests_dll.h b/syzygy/integration_tests/integration_tests_dll.h |
| index c8412a76f723b36ac5c90951b05c315a9d4b079d..019db3602e9aa8c0864d5abf3c1630cc984990a5 100644 |
| --- a/syzygy/integration_tests/integration_tests_dll.h |
| +++ b/syzygy/integration_tests/integration_tests_dll.h |
| @@ -21,11 +21,9 @@ |
| namespace testing { |
| -// This macro declares the tests ids and the function that they're associated |
| +// This macro declares the SygyAsan tests ids and the function that they're associated |
|
Sébastien Marchand
2017/07/04 18:09:04
SyzyAsan (replace the g by a z)
|
| // with. |
| -#define END_TO_END_TEST_ID_TABLE(decl) \ |
| - decl(kArrayComputation1, testing::ArrayComputation1) \ |
| - decl(kArrayComputation2, testing::ArrayComputation2) \ |
| +#define END_TO_END_ASAN_TESTS(decl) \ |
| decl(kAsanRead8BufferOverflow, testing::AsanReadBufferOverflow<int8_t>) \ |
| decl(kAsanRead16BufferOverflow, testing::AsanReadBufferOverflow<int16_t>) \ |
| decl(kAsanRead32BufferOverflow, testing::AsanReadBufferOverflow<int32_t>) \ |
| @@ -150,15 +148,7 @@ namespace testing { |
| decl(kAsanCorruptBlock, testing::AsanCorruptBlock) \ |
| decl(kAsanCorruptBlockInQuarantine, \ |
| testing::AsanCorruptBlockInQuarantine) \ |
| - decl(kBBEntryCallOnce, BBEntryCallOnce) \ |
| - decl(kBBEntryCallTree, BBEntryCallTree) \ |
| - decl(kBBEntryCallRecursive, BBEntryCallRecursive) \ |
| - decl(kCoverage1, testing::coverage_func1) \ |
| - decl(kCoverage2, testing::coverage_func2) \ |
| - decl(kCoverage3, testing::coverage_func3) \ |
| - decl(kProfileCallExport, testing::CallExportedFunction) \ |
| - decl(kProfileGetMyRVA, testing::GetMyRVA) \ |
| - decl(kAsanInvalidAccessWithCorruptAllocatedBlockHeader, \ |
| + decl(kAsanInvalidAccessWithCorruptAllocatedBlockHeader, \ |
|
Sébastien Marchand
2017/07/04 18:09:04
Fix the indentation, you're using tabs here.
|
| testing::AsanInvalidAccessWithCorruptAllocatedBlockHeader) \ |
| decl(kAsanInvalidAccessWithCorruptAllocatedBlockTrailer, \ |
| testing::AsanInvalidAccessWithCorruptAllocatedBlockTrailer) \ |
| @@ -187,6 +177,29 @@ namespace testing { |
| testing::AsanNullptrAccessNoHeapCorruptionUninstrumented) \ |
| decl(kAsanDeferredFreeTLS, testing::AsanDeferredFreeTLS) |
| + |
|
Sébastien Marchand
2017/07/04 18:09:04
Remove the extra BLs.
|
| + |
| +// This macro declares the non SygyAsan tests ids and the function that they're associated |
|
Sébastien Marchand
2017/07/04 18:09:04
> 80 chars.
|
| +// with. |
| +#define END_TO_END_NON_ASAN_TESTS(decl) \ |
| + decl(kArrayComputation1, testing::ArrayComputation1) \ |
| + decl(kArrayComputation2, testing::ArrayComputation2) \ |
| + decl(kBBEntryCallOnce, BBEntryCallOnce) \ |
| + decl(kBBEntryCallTree, BBEntryCallTree) \ |
| + decl(kBBEntryCallRecursive, BBEntryCallRecursive) \ |
| + decl(kCoverage1, testing::coverage_func1) \ |
| + decl(kCoverage2, testing::coverage_func2) \ |
| + decl(kCoverage3, testing::coverage_func3) \ |
| + decl(kProfileCallExport, testing::CallExportedFunction) \ |
| + decl(kProfileGetMyRVA, testing::GetMyRVA) |
| + |
| +// For clang-cl run only the asan tests. |
| +#ifdef __clang__ |
| +#define END_TO_END_TEST_ID_TABLE(decl) END_TO_END_ASAN_TESTS(decl) |
| +#else |
| +#define END_TO_END_TEST_ID_TABLE(decl) END_TO_END_NON_ASAN_TESTS(decl) END_TO_END_ASAN_TESTS(decl) |
|
Sébastien Marchand
2017/07/04 18:09:04
This line is > 80 chars.
|
| +#endif // __clang__ |
| + |
| // This enumeration contains an unique id for each end to end test. It is used |
| // to perform an indirect call through the DLL entry point 'EndToEndTest'. |
| enum EndToEndTestId { |
| @@ -194,7 +207,6 @@ enum EndToEndTestId { |
| END_TO_END_TEST_ID_TABLE(DECLARE_END_TO_END_ENUM) |
| #undef DECLARE_END_TO_END_ENUM |
| }; |
| - |
| } // namespace testing |
| #endif // SYZYGY_INTEGRATION_TESTS_INTEGRATION_TESTS_DLL_H_ |