Moved source files into a list variable and add a custom build target to compile the integration te…

syzygy/integration_tests/integration_tests.gyp

Index: syzygy/integration_tests/integration_tests.gyp
diff --git a/syzygy/integration_tests/integration_tests.gyp b/syzygy/integration_tests/integration_tests.gyp
index 83d1d5ba8210163f8745ffc770c8e948b6b121b2..49ebe552a81ae77428a0d7128adffa9e1ab5cefd 100644
--- a/syzygy/integration_tests/integration_tests.gyp
+++ b/syzygy/integration_tests/integration_tests.gyp
@@ -13,6 +13,30 @@
 # limitations under the License.
 
 {
+  'variables': {
+    'integration_tests_common_source_files': [

[Sébastien Marchand, 2017/07/04 18:09:04]

Add some comments to describe what these list are.

+        'asan_interceptors_tests.cc',
+        'asan_page_protection_tests.cc',
+        'deferred_free_tests.cc',
+        'integration_tests_dll.cc',
+    ],
+    'integration_tests_other_files': [
+        'asan_interceptors_tests.h',
+        'asan_page_protection_tests.h',
+        'bb_entry_tests.h',
+        'bb_entry_tests.cc',
+        'behavior_tests.h',
+        'behavior_tests.cc',
+        'coverage_tests.h',
+        'coverage_tests.cc',
+        'deferred_free_tests.h',
+        'integration_tests_dll.def',
+        'integration_tests_dll.h',
+        'integration_tests_dll.rc',
+        'profile_tests.h',
+        'profile_tests.cc',
+    ]
+  },
   'targets': [
     {
       'target_name': 'integration_tests',
@@ -83,30 +107,32 @@
       ],
     },
     {
+      'target_name': 'integration_tests_clang_dll',
+      'type': 'none',
+      'msvs_cygwin_shell': 0,
+      'actions': [
+        {
+          'action_name': 'make_integration_tests_clang',
+          'inputs': ['<@(integration_tests_common_source_files)'],
+          'outputs': ['<(PRODUCT_DIR)/integration_tests_clang_dll.dll'],
+          'action': [
+              'make_integration_tests_clang.py',
+              '--output-dir=<(PRODUCT_DIR)',
+              '--input-files=<(_inputs)',
+			  '--target-name=integration_tests_clang_dll',

[Sébastien Marchand, 2017/07/04 18:09:04]

Fix the indentation.

+          ],
+        },
+      ],
+    },
+    {
       'target_name': 'integration_tests_dll',
       'type': 'loadable_module',
-      'sources': [
-        'asan_check_tests.h',
-        'asan_interceptors_tests.cc',
-        'asan_interceptors_tests.h',
-        'asan_page_protection_tests.cc',
-        'asan_page_protection_tests.h',
-        'bb_entry_tests.cc',
-        'bb_entry_tests.h',
-        'behavior_tests.cc',
-        'behavior_tests.h',
-        'coverage_tests.cc',
-        'coverage_tests.h',
-        'deferred_free_tests.cc',
-        'deferred_free_tests.h',
-        'integration_tests_dll.cc',
-        'integration_tests_dll.def',
-        'integration_tests_dll.h',
-        'integration_tests_dll.rc',
-        'profile_tests.cc',
-        'profile_tests.h',
-      ],
+      'sources':  [
+        '<@(integration_tests_common_source_files)',
+        '<@(integration_tests_other_files)'
+	  ],

[Sébastien Marchand, 2017/07/04 18:09:04]

Use spaces instead of tabs.

       'dependencies': [
+        '<(src)/base/base.gyp:base',
         '<(src)/syzygy/pe/pe.gyp:export_dll',
         '<(src)/syzygy/version/version.gyp:syzygy_version',
       ],