Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2945913003: Add 1.6x mode. (Closed)

Created:
3 years, 6 months ago by oshima
Modified:
3 years, 6 months ago
Reviewers:
afakhry, drinkcat1
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 1.6x mode. * Remove unsupported 1.5x. * Removed obsolete use_125_dsf_for_ui_scaling flag. (it should be always true) * Added large FHD screen scenario. BUG=734204 BUG=b/62475614 TEST=Updated unit tests. Manual test on cave with manually teaking the scale. Review-Url: https://codereview.chromium.org/2945913003 Cr-Commit-Position: refs/heads/master@{#481042} Committed: https://chromium.googlesource.com/chromium/src/+/2f120a7f827522fa4b6e724b87a399615b86e8ae

Patch Set 1 : Add 1.6x support #

Total comments: 2

Patch Set 2 : Add 1.6x support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -60 lines) Patch
M ash/display/display_manager_unittest.cc View 1 3 chunks +0 lines, -23 lines 0 comments Download
M ui/display/manager/chromeos/display_change_observer.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/display/manager/chromeos/display_change_observer_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/display/manager/display_manager_utilities.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M ui/display/manager/managed_display_info.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/display/manager/managed_display_info.cc View 4 chunks +2 lines, -9 lines 0 comments Download
M ui/display/test/display_manager_test_api.h View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/display/test/display_manager_test_api.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
oshima
3 years, 6 months ago (2017-06-20 18:43:05 UTC) #12
afakhry
lgtm with a nit. https://codereview.chromium.org/2945913003/diff/40001/ash/display/display_manager_unittest.cc File ash/display/display_manager_unittest.cc (right): https://codereview.chromium.org/2945913003/diff/40001/ash/display/display_manager_unittest.cc#newcode1676 ash/display/display_manager_unittest.cc:1676: // display::test::ScopedDisable125DSFForUIScaling disable; Nit: Please ...
3 years, 6 months ago (2017-06-20 19:01:09 UTC) #13
oshima
https://codereview.chromium.org/2945913003/diff/40001/ash/display/display_manager_unittest.cc File ash/display/display_manager_unittest.cc (right): https://codereview.chromium.org/2945913003/diff/40001/ash/display/display_manager_unittest.cc#newcode1676 ash/display/display_manager_unittest.cc:1676: // display::test::ScopedDisable125DSFForUIScaling disable; On 2017/06/20 19:01:09, afakhry wrote: > ...
3 years, 6 months ago (2017-06-20 20:06:41 UTC) #14
drinkcat1
On 2017/06/20 20:06:41, oshima wrote: > https://codereview.chromium.org/2945913003/diff/40001/ash/display/display_manager_unittest.cc > File ash/display/display_manager_unittest.cc (right): > > https://codereview.chromium.org/2945913003/diff/40001/ash/display/display_manager_unittest.cc#newcode1676 > ...
3 years, 6 months ago (2017-06-21 00:06:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945913003/60001
3 years, 6 months ago (2017-06-21 00:22:13 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 00:27:22 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2f120a7f827522fa4b6e724b87a3...

Powered by Google App Engine
This is Rietveld 408576698