Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2945793002:
Discard getDirectorySize request until the last one finishes. (Closed)
|
Created:
3 years, 6 months ago by tetsui Modified:
3 years, 5 months ago Reviewers:
fukino CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDiscard getDirectorySize request until the last one finishes.
fileManagerPrivate.getDirectorySize() was called excessively, because
MetadataBoxController.setDirectorySize_ was called before the last
callback had been finished.
BUG=733143
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2945793002
Cr-Commit-Position: refs/heads/master@{#482528}
Committed: https://chromium.googlesource.com/chromium/src/+/ab62a8b172d7d04bf021d9f010c9a1c9fa92d66b
Patch Set 1 #Patch Set 2 : Improve comment. #
Total comments: 4
Patch Set 3 : Resolve review comments. #Patch Set 4 : Fix compile error. #Messages
Total messages: 28 (21 generated)
Description was changed from ========== Discard getDirectorySize request until the last one finishes. fileManagerPrivate.getDirectorySize() was called excessively, because MetadataBoxController.setDirectorySize_ was called before the last callback had been finished. BUG=733143 TEST=manual ========== to ========== Discard getDirectorySize request until the last one finishes. fileManagerPrivate.getDirectorySize() was called excessively, because MetadataBoxController.setDirectorySize_ was called before the last callback had been finished. BUG=733143 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by tetsui@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tetsui@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tetsui@chromium.org changed reviewers: + fukino@chromium.org
fukino@: PTAL. Thanks!
I'm sorry for a late response! https://codereview.chromium.org/2945793002/diff/20001/ui/file_manager/file_ma... File ui/file_manager/file_manager/foreground/js/metadata_box_controller.js (right): https://codereview.chromium.org/2945793002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:63: this.onDirectorySizeLoaded_ = function(entry) {}; Could you use null instead of empty function object and check the existence of onDirectorySizeLoaded_ in setDirectorySize_ to avoid creating unnecessary function object? https://codereview.chromium.org/2945793002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:234: this.onDirectorySizeLoaded_ = function(entry) {}; You can call setTimeout(finish.bind(null, entry)) to avoid calling finish(entry) in all code paths.
The CQ bit was checked by tetsui@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by tetsui@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2945793002/diff/20001/ui/file_manager/file_ma... File ui/file_manager/file_manager/foreground/js/metadata_box_controller.js (right): https://codereview.chromium.org/2945793002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:63: this.onDirectorySizeLoaded_ = function(entry) {}; On 2017/06/26 08:49:21, fukino wrote: > Could you use null instead of empty function object and check the existence of > onDirectorySizeLoaded_ in setDirectorySize_ to avoid creating unnecessary > function object? Done. https://codereview.chromium.org/2945793002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:234: this.onDirectorySizeLoaded_ = function(entry) {}; On 2017/06/26 08:49:21, fukino wrote: > You can call setTimeout(finish.bind(null, entry)) to avoid calling finish(entry) > in all code paths. Done.
lgtm
Thank you!
The CQ bit was checked by tetsui@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498534108817260,
"parent_rev": "96e54d19b5ae6d0609dc2f31f8bd5267fbd16895", "commit_rev":
"ab62a8b172d7d04bf021d9f010c9a1c9fa92d66b"}
Message was sent while issue was closed.
Description was changed from ========== Discard getDirectorySize request until the last one finishes. fileManagerPrivate.getDirectorySize() was called excessively, because MetadataBoxController.setDirectorySize_ was called before the last callback had been finished. BUG=733143 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Discard getDirectorySize request until the last one finishes. fileManagerPrivate.getDirectorySize() was called excessively, because MetadataBoxController.setDirectorySize_ was called before the last callback had been finished. BUG=733143 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2945793002 Cr-Commit-Position: refs/heads/master@{#482528} Committed: https://chromium.googlesource.com/chromium/src/+/ab62a8b172d7d04bf021d9f010c9... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/ab62a8b172d7d04bf021d9f010c9... |
