Relation properties for Accessibility Object Model phase 1

Relation properties for Accessibility Object Model phase 1

This change implements AOM support for activeDescendant,
details, and errorMessage. The corresponding ARIA attributes
all take IDREFs, and the AOM properties all take references
to AccessibleNodes instead.

This patch finally creates a clean solution for sparse
attribute support: when asked to retrieve sparse attributes
for an AXObject, we first get all AOM properties, and we
also get a list of corresponding ARIA attributes. Then we
iterate over the Element attributes and check for ARIA
attributes, skipping any that were shadowed by AOM
attributes.

BUG=680345
Review-Url: https://codereview.chromium.org/2945773002
Cr-Commit-Position: refs/heads/master@{#481580}
Committed: https://chromium.googlesource.com/chromium/src/+/f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b

[dmazzoni, 2017-06-19 07:55:20]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 07:55:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 08:07:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 08:07:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-06-19 23:07:50]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2017-06-19 23:07:58]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[commit-bot: I haz the power, 2017-06-19 23:08:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 23:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 23:47:44]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aboxhall, 2017-06-20 01:11:44]

https://codereview.chromium.org/2945773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/AccessibleNode.cpp (right):

https://codereview.chromium.org/2945773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/AccessibleNode.cpp:302: QualifiedName
attribute = GetCorrespondingARIAAttribute(property);
Nice.

https://codereview.chromium.org/2945773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2945773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:241: void
AddBooleanProperty(AOMBooleanProperty property, bool value) override {}
Are these still TODO..?

[dmazzoni, 2017-06-20 04:56:34]

https://codereview.chromium.org/2945773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2945773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:241: void
AddBooleanProperty(AOMBooleanProperty property, bool value) override {}
On 2017/06/20 01:11:43, aboxhall wrote:
> Are these still TODO..?

Not exactly.

AOMPropertyClient iterates over every supported AOM property.

AXSparseAttributeClient only supports a handful of attributes so far.
Over time we'd like to have more sparse attributes, but right now the
only ones we support are 2 string, 3 object attributes, and 3 object
vector attributes (which will be added to AOM next).

The way this is written, making more accessibility attributes sparse
won't require any changes to AccessibleNode.

[dmazzoni, 2017-06-20 21:38:00]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 21:38:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 23:51:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 23:51:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-06-20 23:57:44]

dmazzoni@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dmazzoni, 2017-06-20 23:57:44]

OK, I think this is ready. The only remaining test failures are webexposed/, the
latest patch set should fix that.

+dglazkov for OWNERS review

[dmazzoni, 2017-06-20 23:57:54]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 23:58:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 02:23:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 02:23:05]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2017-06-21 14:32:07]

lgtm

[aboxhall, 2017-06-22 01:12:39]

lgtm

https://codereview.chromium.org/2945773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2945773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:241: void
AddBooleanProperty(AOMBooleanProperty property, bool value) override {}
On 2017/06/20 04:56:34, dmazzoni wrote:
> On 2017/06/20 01:11:43, aboxhall wrote:
> > Are these still TODO..?
> 
> Not exactly.
> 
> AOMPropertyClient iterates over every supported AOM property.
> 
> AXSparseAttributeClient only supports a handful of attributes so far.
> Over time we'd like to have more sparse attributes, but right now the
> only ones we support are 2 string, 3 object attributes, and 3 object
> vector attributes (which will be added to AOM next).
> 
> The way this is written, making more accessibility attributes sparse
> won't require any changes to AccessibleNode.

Ah, got it. Thanks for explaining.

[dmazzoni, 2017-06-22 05:33:45]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 05:37:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 05:56:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 05:56:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-06-22 15:07:45]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 15:10:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-06-22 16:18:20]

The CQ bit was unchecked by dmazzoni@chromium.org

[dmazzoni, 2017-06-22 16:18:26]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-06-22 16:18:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dglazkov@chromium.org, aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2945773002/#ps100001
(title: "Fix merge error, format")

[commit-bot: I haz the power, 2017-06-22 16:18:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 17:25:10]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498148306353760,
"parent_rev": "176ea346000f88605064bbe99bd5210134ed9077", "commit_rev":
"f5c2c5878f36c17467f901b2d8f659bb7cd8ac0b"}

[commit-bot: I haz the power, 2017-06-22 17:25:24]

Description was changed from

==========
Relation properties for Accessibility Object Model phase 1

This change implements AOM support for activeDescendant,
details, and errorMessage. The corresponding ARIA attributes
all take IDREFs, and the AOM properties all take references
to AccessibleNodes instead.

This patch finally creates a clean solution for sparse
attribute support: when asked to retrieve sparse attributes
for an AXObject, we first get all AOM properties, and we
also get a list of corresponding ARIA attributes. Then we
iterate over the Element attributes and check for ARIA
attributes, skipping any that were shadowed by AOM
attributes.

BUG=680345
==========

to

==========
Relation properties for Accessibility Object Model phase 1

This change implements AOM support for activeDescendant,
details, and errorMessage. The corresponding ARIA attributes
all take IDREFs, and the AOM properties all take references
to AccessibleNodes instead.

This patch finally creates a clean solution for sparse
attribute support: when asked to retrieve sparse attributes
for an AXObject, we first get all AOM properties, and we
also get a list of corresponding ARIA attributes. Then we
iterate over the Element attributes and check for ARIA
attributes, skipping any that were shadowed by AOM
attributes.

BUG=680345

Review-Url: https://codereview.chromium.org/2945773002
Cr-Commit-Position: refs/heads/master@{#481580}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5c2c5878f36c17467f901b2d8f6...
==========

[commit-bot: I haz the power, 2017-06-22 17:25:26]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f5c2c5878f36c17467f901b2d8f6...