Move process_version_rc_template.gni to build/util

Move process_version_rc_template.gni to build/util

Having process_version_rc_template.gni in //chrome creates some unwanted
dependencies (such as //base depending on //chrome). These dependencies
create problems for external projects that want to depend on //base but
not on //chrome.

Proper functionality of process_version_rc_template.gni relies on the
branding file at "//chrome/app/theme/$branding_path_component/BRANDING"
to be present. External projects that do use process_version_rc_template
will still need to depend on Chrome.
See //src/build/util/branding.gni for a comparable existing dependency
from //build to //chrome.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

[proberge, 2017-06-19 15:27:59]

Description was changed from

==========
Move process_version_rc_template.gni to build/util

Having process_version_rc_template.gni in //chrome creates some unwanted
dependencies (such as //base depending on //chrome). These dependencies
create problems for external projects that want to depend on //base but
not on //chrome.

Proper functionality of process_version_rc_template.gni relies on the
branding file at "//chrome/app/theme/$branding_path_component/BRANDING"
to be present. External projects that do use process_version_rc_template
will still need to depend on Chrome.
See //src/build/util/branding.gni for a comparable existing dependency
from //build to //chrome.

BUG=
==========

to

==========
Move process_version_rc_template.gni to build/util

Having process_version_rc_template.gni in //chrome creates some unwanted
dependencies (such as //base depending on //chrome). These dependencies
create problems for external projects that want to depend on //base but
not on //chrome.

Proper functionality of process_version_rc_template.gni relies on the
branding file at "//chrome/app/theme/$branding_path_component/BRANDING"
to be present. External projects that do use process_version_rc_template
will still need to depend on Chrome.
See //src/build/util/branding.gni for a comparable existing dependency
from //build to //chrome.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[proberge, 2017-06-19 15:29:22]

Description was changed from

==========
Move process_version_rc_template.gni to build/util

Having process_version_rc_template.gni in //chrome creates some unwanted
dependencies (such as //base depending on //chrome). These dependencies
create problems for external projects that want to depend on //base but
not on //chrome.

Proper functionality of process_version_rc_template.gni relies on the
branding file at "//chrome/app/theme/$branding_path_component/BRANDING"
to be present. External projects that do use process_version_rc_template
will still need to depend on Chrome.
See //src/build/util/branding.gni for a comparable existing dependency
from //build to //chrome.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Move process_version_rc_template.gni to build/util

Having process_version_rc_template.gni in //chrome creates some unwanted
dependencies (such as //base depending on //chrome). These dependencies
create problems for external projects that want to depend on //base but
not on //chrome.

Proper functionality of process_version_rc_template.gni relies on the
branding file at "//chrome/app/theme/$branding_path_component/BRANDING"
to be present. External projects that do use process_version_rc_template
will still need to depend on Chrome.
See //src/build/util/branding.gni for a comparable existing dependency
from //build to //chrome.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[proberge, 2017-06-19 15:29:22]

proberge@chromium.org changed reviewers:
+ grt@chromium.org

[proberge, 2017-06-19 15:31:06]

See post-submit comments on https://codereview.chromium.org/2687783003 for
additional context.

[proberge, 2017-06-19 15:31:50]

proberge@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[grt (UTC plus 2), 2017-06-20 09:57:02]

This change would put a dependency on //chrome into
//build/util/process_version_rc_template.gni, no? Is that an improvement?

Can these non-chrome targets use the process_version template directly rather
than //chrome's process_version_rc_template?

[proberge, 2017-06-20 18:56:16]

On 2017/06/20 09:57:02, grt (UTC plus 2) wrote:
> This change would put a dependency on //chrome into
> //build/util/process_version_rc_template.gni, no? Is that an improvement?

I thought it would be an improvement as it removed a hard GN dependency, instead
failing only if the project indirectly called process_version_rc_template
without
//chrome in the checkout.

I can see that the functionality improvement might not be worth a misleading
indirect dependency.

> Can these non-chrome targets use the process_version template directly rather
> than //chrome's process_version_rc_template?

Non-chrome targets could use the process_version template directly, but to get
the same .rc file output they would need to add 
//chrome/app/theme/$branding_path_component/BRANDING as a source in the template
call.

I actually just care about //base, so an alternative solution would be to move
the
code in //base which uses the template to //chrome. 
See https://codereview.chromium.org/2946983002/

[grt (UTC plus 2), 2017-06-21 09:31:39]

On 2017/06/20 18:56:16, proberge wrote:
> I actually just care about //base, so an alternative solution would be to move
> the
> code in //base which uses the template to //chrome. 
> See https://codereview.chromium.org/2946983002/

I think this is the right thing to do. I've commented in that CR.