Create BrowserUserData.

Create BrowserUserData.

This CL updates Browser to subclass base::SupportsUserData, and adds
BrowserUserData, which includes functionality analogous to
WebStateUserData.

BUG=none

Review-Url: https://codereview.chromium.org/2945713002
Cr-Commit-Position: refs/heads/master@{#481821}
Committed: https://chromium.googlesource.com/chromium/src/+/5b0a572abb7483a5d93d242aa34be9a09d3883d4

[kkhorimoto, 2017-06-17 01:52:02]

kkhorimoto@chromium.org changed reviewers:
+ marq@chromium.org

[marq (ping after 24h), 2017-06-18 08:41:30]

marq@chromium.org changed reviewers:
+ rohitrao@chromium.org, sdefresne@chromium.org

[marq (ping after 24h), 2017-06-18 08:41:31]

+rohitrao@ +sdefresne@

[rohitrao (ping after 24h), 2017-06-19 12:39:30]

I'd like sdefresne to review the actual code changes.

What do we need this for?

[sdefresne, 2017-06-19 12:46:24]

On 2017/06/19 12:39:30, rohitrao (ping after 24h) wrote:
> I'd like sdefresne to review the actual code changes.
> 
> What do we need this for?

The changes lg but I also want to know why we need this.

Which object need to be tied to a Browser and cannot be tied to the
ChromeBrowserState?

[kkhorimoto, 2017-06-19 17:50:58]

On 2017/06/19 12:46:24, sdefresne wrote:
> On 2017/06/19 12:39:30, rohitrao (ping after 24h) wrote:
> > I'd like sdefresne to review the actual code changes.
> > 
> > What do we need this for?
> 
> The changes lg but I also want to know why we need this.
> 
> Which object need to be tied to a Browser and cannot be tied to the
> ChromeBrowserState?

BrowserStates contain a BrowserList, so there can (ostensibly) be multiple
Browsers in the app.  I'm not super familiar what exactly it means to have
multiple Browsers, but having a Browser-level data object holder is useful to
have a complete implementation.  For reference, this is to support
OverlayService (https://codereview.chromium.org/2921833002), which exists at a
ChromeBrowserState level, creates BrowserUserData objects as the result of
BrowserListObserver callbacks.

[marq (ping after 24h), 2017-06-20 14:51:12]

On 2017/06/19 17:50:58, kkhorimoto_ wrote:
> On 2017/06/19 12:46:24, sdefresne wrote:
> > On 2017/06/19 12:39:30, rohitrao (ping after 24h) wrote:
> > > I'd like sdefresne to review the actual code changes.
> > > 
> > > What do we need this for?
> > 
> > The changes lg but I also want to know why we need this.
> > 
> > Which object need to be tied to a Browser and cannot be tied to the
> > ChromeBrowserState?
> 
> BrowserStates contain a BrowserList, so there can (ostensibly) be multiple
> Browsers in the app.  I'm not super familiar what exactly it means to have
> multiple Browsers, but having a Browser-level data object holder is useful to
> have a complete implementation.  For reference, this is to support
> OverlayService (https://codereview.chromium.org/2921833002), which exists at a
> ChromeBrowserState level, creates BrowserUserData objects as the result of
> BrowserListObserver callbacks.

This is relevant for the other reasons we've decided the Browser distinction is
relevant —
to make it possible to support separate groups of tabs from the same browser
states. The 
overlay-supporting classes built in the dependent CLs are logically per-browser.

[marq (ping after 24h), 2017-06-20 14:54:05]

lgtm

https://codereview.chromium.org/2945713002/diff/1/ios/shared/chrome/browser/u...
File ios/shared/chrome/browser/ui/browser_list/browser_user_data.h (right):

https://codereview.chromium.org/2945713002/diff/1/ios/shared/chrome/browser/u...
ios/shared/chrome/browser/ui/browser_list/browser_user_data.h:26: // --- in
foo.cc ---
Overwhelmingly likely that we'll have foo.mm rather than foo.cc

https://codereview.chromium.org/2945713002/diff/1/ios/shared/chrome/browser/u...
ios/shared/chrome/browser/ui/browser_list/browser_user_data.h:63: // The macro
to define the locator key. This key should be defined in the .cc
s/.cc/.mm/ or better yet, "implementation".

[sdefresne, 2017-06-22 13:44:22]

lgtm as we already have a need for this

[kkhorimoto, 2017-06-23 06:02:00]

rebase

[kkhorimoto, 2017-06-23 06:02:01]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-06-23 06:02:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org, marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2945713002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-23 06:02:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kkhorimoto, 2017-06-23 06:02:11]

https://codereview.chromium.org/2945713002/diff/1/ios/shared/chrome/browser/u...
File ios/shared/chrome/browser/ui/browser_list/browser_user_data.h (right):

https://codereview.chromium.org/2945713002/diff/1/ios/shared/chrome/browser/u...
ios/shared/chrome/browser/ui/browser_list/browser_user_data.h:26: // --- in
foo.cc ---
On 2017/06/20 14:54:05, marq (ping after 24h) wrote:
> Overwhelmingly likely that we'll have foo.mm rather than foo.cc

Done.

https://codereview.chromium.org/2945713002/diff/1/ios/shared/chrome/browser/u...
ios/shared/chrome/browser/ui/browser_list/browser_user_data.h:63: // The macro
to define the locator key. This key should be defined in the .cc
On 2017/06/20 14:54:05, marq (ping after 24h) wrote:
> s/.cc/.mm/ or better yet, "implementation".

Done.

[commit-bot: I haz the power, 2017-06-23 07:15:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498197721718550,
"parent_rev": "87cb08e7101f8ab1eb043407464091863d0419bd", "commit_rev":
"5b0a572abb7483a5d93d242aa34be9a09d3883d4"}

[commit-bot: I haz the power, 2017-06-23 07:15:33]

Description was changed from

==========
Create BrowserUserData.

This CL updates Browser to subclass base::SupportsUserData, and adds
BrowserUserData, which includes functionality analogous to
WebStateUserData.

BUG=none
==========

to

==========
Create BrowserUserData.

This CL updates Browser to subclass base::SupportsUserData, and adds
BrowserUserData, which includes functionality analogous to
WebStateUserData.

BUG=none

Review-Url: https://codereview.chromium.org/2945713002
Cr-Commit-Position: refs/heads/master@{#481821}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b0a572abb7483a5d93d242aa34b...
==========

[commit-bot: I haz the power, 2017-06-23 07:15:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b0a572abb7483a5d93d242aa34b...