Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2945663002: Add hint about pre-installed nodejs and npm install in infra Go env. (Closed)

Created:
3 years, 6 months ago by tandrii(chromium)
Modified:
3 years, 6 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Add hint about pre-installed nodejs and npm install in infra Go env. R=hinoka@chromium.org BUG= Review-Url: https://codereview.chromium.org/2945663002 Committed: https://github.com/luci/luci-go/commit/a986b4c74e7bb8de370d1a8aa6784a4c5ccbddd8

Patch Set 1 #

Total comments: 2

Patch Set 2 : reword #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M web/README.md View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tandrii(chromium)
3 years, 6 months ago (2017-06-16 19:42:50 UTC) #1
Ryan Tseng
lgtm https://codereview.chromium.org/2945663002/diff/1/web/README.md File web/README.md (right): https://codereview.chromium.org/2945663002/diff/1/web/README.md#newcode9 web/README.md:9: in your path after `eval ./env.go`. Maybe word ...
3 years, 6 months ago (2017-06-16 19:48:35 UTC) #5
tandrii(chromium)
https://codereview.chromium.org/2945663002/diff/1/web/README.md File web/README.md (right): https://codereview.chromium.org/2945663002/diff/1/web/README.md#newcode9 web/README.md:9: in your path after `eval ./env.go`. On 2017/06/16 19:48:35, ...
3 years, 6 months ago (2017-06-16 19:51:29 UTC) #8
Ryan Tseng
yep
3 years, 6 months ago (2017-06-16 20:19:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945663002/20001
3 years, 6 months ago (2017-06-16 20:30:51 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 20:39:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/a986b4c74e7bb8de370d1a8aa6784a4c5ccbddd8

Powered by Google App Engine
This is Rietveld 408576698