Remove the legacy (extension-notifier) usb printer detector. Rename the remaining printerdetector …

Remove the legacy (extension-notifier) usb printer detector.  

Also, Rename the remaining printerdetector with the less prefix 'Usb' in preparation for other work on printer detection.

BUG=734161
Review-Url: https://codereview.chromium.org/2945653002
Cr-Commit-Position: refs/heads/master@{#480267}
Committed: https://chromium.googlesource.com/chromium/src/+/77ddcddc4b0adad18246c1bea349dd7b5129357f

[Carlson, 2017-06-16 19:01:05]

The CQ bit was checked by justincarlson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 19:01:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Carlson, 2017-06-16 19:01:43]

justincarlson@chromium.org changed reviewers:
+ skau@chromium.org

[Carlson, 2017-06-16 19:01:43]

Cleaning up before doing the interface refactor.

[commit-bot: I haz the power, 2017-06-16 20:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 20:27:39]

Dry run: This issue passed the CQ dry run.

[skau, 2017-06-16 22:39:09]

lgtm

[Carlson, 2017-06-16 22:45:40]

justincarlson@chromium.org changed reviewers:
+ thestig@chromium.org

[Carlson, 2017-06-16 22:45:41]

Lei, I suspect you have as much state on this as any of the owners, would you
mind taking a look for OWNERS signoff?

[Lei Zhang, 2017-06-16 23:08:43]

Add a couple of carriage returns after the first sentence in the CL description?

chrome/browser/chromeos/printer_detector/usb_printer_detector.h is showing up as
a "new" file. Do you want to try to git cl upload with some --similarity=NN
tweak, to convince Rietveld that it's actually a move?

[Lei Zhang, 2017-06-16 23:11:25]

lgtm

https://codereview.chromium.org/2945653002/diff/1/chrome/browser/chromeos/pri...
File chrome/browser/chromeos/printer_detector/usb_printer_detector_factory.cc
(right):

https://codereview.chromium.org/2945653002/diff/1/chrome/browser/chromeos/pri...
chrome/browser/chromeos/printer_detector/usb_printer_detector_factory.cc:20:
static base::LazyInstance<UsbPrinterDetectorFactory>::DestructorAtExit
BTW, you don't need static inside an anonymous namespace.

[Carlson, 2017-06-16 23:14:02]

Description was changed from

==========
Remove the legacy (extension-notifier) usb printer detector.  Rename the
remaining printerdetector with the less prefix 'Usb' in preparation for other
work on printer detection.

BUG=734161
==========

to

==========
Remove the legacy (extension-notifier) usb printer detector.  

Also, Rename the remaining printerdetector with the less prefix 'Usb' in
preparation for other work on printer detection.

BUG=734161
==========

[Carlson, 2017-06-16 23:15:52]

Updated description, addressed comment.

https://codereview.chromium.org/2945653002/diff/1/chrome/browser/chromeos/pri...
File chrome/browser/chromeos/printer_detector/usb_printer_detector_factory.cc
(right):

https://codereview.chromium.org/2945653002/diff/1/chrome/browser/chromeos/pri...
chrome/browser/chromeos/printer_detector/usb_printer_detector_factory.cc:20:
static base::LazyInstance<UsbPrinterDetectorFactory>::DestructorAtExit
On 2017/06/16 23:11:24, Lei Zhang wrote:
> BTW, you don't need static inside an anonymous namespace

Done

[Carlson, 2017-06-16 23:17:22]

The CQ bit was checked by justincarlson@chromium.org

[Carlson, 2017-06-16 23:17:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, skau@chromium.org
Link to the patchset: https://codereview.chromium.org/2945653002/#ps20001
(title: "Remove the legacy (extension-notifier) usb printer detector.  Rename
the remaining printerdetector …")

[commit-bot: I haz the power, 2017-06-16 23:17:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-17 00:41:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-17 00:41:52]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Carlson, 2017-06-17 00:44:09]

The CQ bit was checked by justincarlson@chromium.org

[commit-bot: I haz the power, 2017-06-17 00:44:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-17 01:53:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497660249092030,
"parent_rev": "ba7d2a4286782b977191392e2d3ff128e995dd35", "commit_rev":
"77ddcddc4b0adad18246c1bea349dd7b5129357f"}

[commit-bot: I haz the power, 2017-06-17 01:53:23]

Description was changed from

==========
Remove the legacy (extension-notifier) usb printer detector.  

Also, Rename the remaining printerdetector with the less prefix 'Usb' in
preparation for other work on printer detection.

BUG=734161
==========

to

==========
Remove the legacy (extension-notifier) usb printer detector.  

Also, Rename the remaining printerdetector with the less prefix 'Usb' in
preparation for other work on printer detection.

BUG=734161

Review-Url: https://codereview.chromium.org/2945653002
Cr-Commit-Position: refs/heads/master@{#480267}
Committed:
https://chromium.googlesource.com/chromium/src/+/77ddcddc4b0adad18246c1bea349...
==========

[commit-bot: I haz the power, 2017-06-17 01:53:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/77ddcddc4b0adad18246c1bea349...