Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2945553002: Remove Kernel*Set classes. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove Kernel*Set classes. These classes are no longer needed, since we use KernelComplexAssignment (and derived classes) to represent assignments. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/f5ea0a4403d69f07fefaee95910193fd081232c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -136 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 6 chunks +7 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 5 chunks +0 lines, -126 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Paul Berry
3 years, 6 months ago (2017-06-16 04:11:42 UTC) #2
ahe
lgtm
3 years, 6 months ago (2017-06-16 13:02:24 UTC) #4
Paul Berry
Committed patchset #1 (id:1) manually as f5ea0a4403d69f07fefaee95910193fd081232c1 (presubmit successful).
3 years, 6 months ago (2017-06-16 13:57:57 UTC) #6
scheglov
3 years, 6 months ago (2017-06-16 15:16:25 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698