Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Issue 2945553002: Remove Kernel*Set classes. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
index f399fa34020c504e66294ce0281f024fddba4bef..dd84d842cc5bb6c2e506a7f8a89eebcc8a568ee8 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
@@ -578,30 +578,6 @@ class KernelDirectPropertyGet extends DirectPropertyGet
}
}
-/// Shadow object for [DirectPropertySet].
-class KernelDirectPropertySet extends DirectPropertySet
- implements KernelExpression {
- KernelDirectPropertySet(Expression receiver, Member target, Expression value)
- : super(receiver, target, value);
-
- KernelDirectPropertySet.byReference(
- Expression receiver, Reference targetReference, Expression value)
- : super.byReference(receiver, targetReference, value);
-
- @override
- void _collectDependencies(KernelDependencyCollector collector) {
- // Assignment expressions are not immediately evident expressions.
- collector.recordNotImmediatelyEvident(fileOffset);
- }
-
- @override
- DartType _inferExpression(
- KernelTypeInferrer inferrer, DartType typeContext, bool typeNeeded) {
- // TODO(scheglov): implement.
- return typeNeeded ? const DynamicType() : null;
- }
-}
-
/// Concrete shadow object representing a double literal in kernel form.
class KernelDoubleLiteral extends DoubleLiteral implements KernelExpression {
KernelDoubleLiteral(double value) : super(value);
@@ -1493,39 +1469,6 @@ class KernelPropertyGet extends PropertyGet implements KernelExpression {
}
}
-/// Shadow object for [PropertyGet].
-class KernelPropertySet extends PropertySet implements KernelExpression {
- KernelPropertySet(Expression receiver, Name name, Expression value,
- [Member interfaceTarget])
- : super(receiver, name, value, interfaceTarget);
-
- KernelPropertySet.byReference(Expression receiver, Name name,
- Expression value, Reference interfaceTargetReference)
- : super.byReference(receiver, name, value, interfaceTargetReference);
-
- @override
- void _collectDependencies(KernelDependencyCollector collector) {
- // Assignment expressions are not immediately evident expressions.
- collector.recordNotImmediatelyEvident(fileOffset);
- }
-
- @override
- DartType _inferExpression(
- KernelTypeInferrer inferrer, DartType typeContext, bool typeNeeded) {
- typeNeeded =
- inferrer.listener.propertySetEnter(this, typeContext) || typeNeeded;
- // First infer the receiver so we can look up the setter that was invoked.
- var receiverType = inferrer.inferExpression(receiver, null, true);
- Member interfaceMember = inferrer
- .findInterfaceMember(receiverType, name, fileOffset, setter: true);
- interfaceTarget = interfaceMember;
- var setterType = inferrer.getSetterType(interfaceMember, receiverType);
- var inferredType = inferrer.inferExpression(value, setterType, typeNeeded);
- inferrer.listener.propertySetExit(this, inferredType);
- return typeNeeded ? inferredType : null;
- }
-}
-
/// Concrete shadow object representing a redirecting initializer in kernel
/// form.
class KernelRedirectingInitializer extends RedirectingInitializer
@@ -1696,27 +1639,6 @@ class KernelStaticInvocation extends StaticInvocation
}
}
-/// Shadow object for [StaticSet].
-class KernelStaticSet extends StaticSet implements KernelExpression {
- KernelStaticSet(Member target, Expression value) : super(target, value);
-
- KernelStaticSet.byReference(Reference targetReference, Expression value)
- : super.byReference(targetReference, value);
-
- @override
- void _collectDependencies(KernelDependencyCollector collector) {
- // Assignment expressions are not immediately evident expressions.
- collector.recordNotImmediatelyEvident(fileOffset);
- }
-
- @override
- DartType _inferExpression(
- KernelTypeInferrer inferrer, DartType typeContext, bool typeNeeded) {
- // TODO(scheglov): implement.
- return typeNeeded ? const DynamicType() : null;
- }
-}
-
/// Concrete shadow object representing a string concatenation in kernel form.
class KernelStringConcatenation extends StringConcatenation
implements KernelExpression {
@@ -1817,30 +1739,6 @@ class KernelSuperPropertyGet extends SuperPropertyGet
}
}
-/// Shadow object for [SuperPropertySet].
-class KernelSuperPropertySet extends SuperPropertySet
- implements KernelExpression {
- KernelSuperPropertySet(Name name, Expression value, Member interfaceTarget)
- : super(name, value, interfaceTarget);
-
- KernelSuperPropertySet.byReference(
- Name name, Expression value, Reference interfaceTargetReference)
- : super.byReference(name, value, interfaceTargetReference);
-
- @override
- void _collectDependencies(KernelDependencyCollector collector) {
- // Assignment expressions are not immediately evident expressions.
- collector.recordNotImmediatelyEvident(fileOffset);
- }
-
- @override
- DartType _inferExpression(
- KernelTypeInferrer inferrer, DartType typeContext, bool typeNeeded) {
- // TODO(scheglov): implement.
- return typeNeeded ? const DynamicType() : null;
- }
-}
-
/// Shadow object for [SymbolLiteral].
class KernelSymbolLiteral extends SymbolLiteral implements KernelExpression {
KernelSymbolLiteral(String value) : super(value);
@@ -2225,30 +2123,6 @@ class KernelVariableGet extends VariableGet implements KernelExpression {
}
}
-/// Concrete shadow object representing a write to a variable in kernel form.
-class KernelVariableSet extends VariableSet implements KernelExpression {
- KernelVariableSet(VariableDeclaration variable, Expression value)
- : super(variable, value);
-
- @override
- void _collectDependencies(KernelDependencyCollector collector) {
- // Assignment expressions are not immediately evident expressions.
- collector.recordNotImmediatelyEvident(fileOffset);
- }
-
- @override
- DartType _inferExpression(
- KernelTypeInferrer inferrer, DartType typeContext, bool typeNeeded) {
- var variable = this.variable as KernelVariableDeclaration;
- typeNeeded =
- inferrer.listener.variableSetEnter(this, typeContext) || typeNeeded;
- var inferredType =
- inferrer.inferExpression(value, variable.type, typeNeeded);
- inferrer.listener.variableSetExit(this, inferredType);
- return inferredType;
- }
-}
-
/// Concrete shadow object representing a yield statement in kernel form.
class KernelYieldStatement extends YieldStatement implements KernelStatement {
KernelYieldStatement(Expression expression, {bool isYieldStar: false})
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698