[Extensions Bindings] Update IME custom bindings

[Extensions Bindings] Update IME custom bindings

Update IME custom bindings to not rely on JS Event bindings.

BUG=653596
BUG=733825
TEST=browser_tests --gtest_filter=InputImeApiTest.BasicApiTest
                   --native-crx-bindings=1

Review-Url: https://codereview.chromium.org/2945493002
Cr-Commit-Position: refs/heads/master@{#480223}
Committed: https://chromium.googlesource.com/chromium/src/+/15b908ccd529a9ddab8dd9af94c0cdd72cb5b429

[Devlin, 2017-06-15 21:36:03]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 21:36:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 22:51:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 22:51:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-06-16 00:59:39]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 01:00:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-16 01:41:10]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 01:41:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-16 02:09:33]

Patchset #2 (id:20001) has been deleted

[Devlin, 2017-06-16 02:09:41]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-06-16 04:03:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 04:03:04]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-16 14:45:18]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org, lazyboy@chromium.org

[Devlin, 2017-06-16 14:45:19]

A fun one...

https://codereview.chromium.org/2945493002/diff/40001/chrome/renderer/resourc...
File chrome/renderer/resources/extensions/input.ime_custom_bindings.js (right):

https://codereview.chromium.org/2945493002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/extensions/input.ime_custom_bindings.js:14: //
TODO(crbug.com/733825): These bindings have some issues.
There's still quite a few fundamental issues in these bindings, but they're now
at least as compatible with native bindings as they were with JS bindings.  I've
filed this bug about the rest.

[jbroman, 2017-06-16 19:00:03]

lgtm

[lazyboy, 2017-06-16 21:10:19]

lgtm

https://codereview.chromium.org/2945493002/diff/40001/chrome/renderer/resourc...
File chrome/renderer/resources/extensions/input.ime_custom_bindings.js (right):

https://codereview.chromium.org/2945493002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/extensions/input.ime_custom_bindings.js:22: //
Dispatch is weird - it returns an object {results: array<results>} iff
s/Dispatch/dispatch()

[Devlin, 2017-06-16 22:28:43]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 22:29:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-16 23:29:51]

https://codereview.chromium.org/2945493002/diff/40001/chrome/renderer/resourc...
File chrome/renderer/resources/extensions/input.ime_custom_bindings.js (right):

https://codereview.chromium.org/2945493002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/extensions/input.ime_custom_bindings.js:22: //
Dispatch is weird - it returns an object {results: array<results>} iff
On 2017/06/16 21:10:19, lazyboy wrote:
> s/Dispatch/dispatch()

Done.

[Devlin, 2017-06-16 23:29:55]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-16 23:29:58]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-16 23:29:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
lazyboy@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2945493002/#ps60001
(title: "s/Dispatch/dispatch()")

[commit-bot: I haz the power, 2017-06-16 23:30:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 23:41:23]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497655798508350,
"parent_rev": "ef0848879420e9da7ebe1e24c1fc5ad2e913f684", "commit_rev":
"15b908ccd529a9ddab8dd9af94c0cdd72cb5b429"}

[commit-bot: I haz the power, 2017-06-16 23:41:35]

Description was changed from

==========
[Extensions Bindings] Update IME custom bindings

Update IME custom bindings to not rely on JS Event bindings.

BUG=653596
BUG=733825
TEST=browser_tests --gtest_filter=InputImeApiTest.BasicApiTest
                   --native-crx-bindings=1
==========

to

==========
[Extensions Bindings] Update IME custom bindings

Update IME custom bindings to not rely on JS Event bindings.

BUG=653596
BUG=733825
TEST=browser_tests --gtest_filter=InputImeApiTest.BasicApiTest
                   --native-crx-bindings=1

Review-Url: https://codereview.chromium.org/2945493002
Cr-Commit-Position: refs/heads/master@{#480223}
Committed:
https://chromium.googlesource.com/chromium/src/+/15b908ccd529a9ddab8dd9af94c0...
==========

[commit-bot: I haz the power, 2017-06-16 23:41:36]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/15b908ccd529a9ddab8dd9af94c0...