cros: update app list item view for all apps grid view

cros: update app list item view for all apps grid view

Changes:
(1) app list item view, which is used for all apps grid view, has the
same tile layout (icon, title, and their paddings) requirement as start
page recommended apps tile.
(2) fix recommended apps tile title width issue: it has 80px width
requirement, we just need to set left and right 8px insets for it.

R=xiyuan@chromium.org
CC=newcomer@chromium.org, weidongg@chromium.org
BUG=735702
TEST=tested with and without --enable-features=EnableFullscreenAppList
flag

Review-Url: https://codereview.chromium.org/2945343003
Cr-Commit-Position: refs/heads/master@{#481720}
Committed: https://chromium.googlesource.com/chromium/src/+/1948539699b040fc84719d100788d393260efe95

[Qiang(Joe) Xu, 2017-06-22 22:22:03]

Hi xiyuan, PTAL thanks

[xiyuan, 2017-06-22 22:44:14]

https://codereview.chromium.org/2945343003/diff/20001/ui/app_list/views/app_l...
File ui/app_list/views/app_list_item_view.cc (right):

https://codereview.chromium.org/2945343003/diff/20001/ui/app_list/views/app_l...
ui/app_list/views/app_list_item_view.cc:86: gfx::FontList base_font =
gfx::FontList -> const gfx::FontList&

https://codereview.chromium.org/2945343003/diff/20001/ui/app_list/views/app_l...
ui/app_list/views/app_list_item_view.cc:93: static const gfx::FontList font_list
= GetFontList();
Get rid of "static"

and 

   const gfx::FontList
-> const gfx::FontList&

https://codereview.chromium.org/2945343003/diff/20001/ui/app_list/views/searc...
File ui/app_list/views/search_result_tile_item_view.cc (right):

https://codereview.chromium.org/2945343003/diff/20001/ui/app_list/views/searc...
ui/app_list/views/search_result_tile_item_view.cc:263: else if
(item_->display_type() == SearchResult::DISPLAY_TILE)
no else after return

See
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

[Qiang(Joe) Xu, 2017-06-22 22:55:39]

feedback addressed, thanks

https://codereview.chromium.org/2945343003/diff/20001/ui/app_list/views/app_l...
File ui/app_list/views/app_list_item_view.cc (right):

https://codereview.chromium.org/2945343003/diff/20001/ui/app_list/views/app_l...
ui/app_list/views/app_list_item_view.cc:86: gfx::FontList base_font =
On 2017/06/22 22:44:14, xiyuan wrote:
> gfx::FontList -> const gfx::FontList&

Done.

https://codereview.chromium.org/2945343003/diff/20001/ui/app_list/views/app_l...
ui/app_list/views/app_list_item_view.cc:93: static const gfx::FontList font_list
= GetFontList();
On 2017/06/22 22:44:14, xiyuan wrote:
> Get rid of "static"
> 
> and 
> 
>    const gfx::FontList
> -> const gfx::FontList&

Done.

https://codereview.chromium.org/2945343003/diff/20001/ui/app_list/views/searc...
File ui/app_list/views/search_result_tile_item_view.cc (right):

https://codereview.chromium.org/2945343003/diff/20001/ui/app_list/views/searc...
ui/app_list/views/search_result_tile_item_view.cc:263: else if
(item_->display_type() == SearchResult::DISPLAY_TILE)
On 2017/06/22 22:44:14, xiyuan wrote:
> no else after return
> 
> See
>
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

acknowledged, done.

[xiyuan, 2017-06-22 22:56:15]

lgtm

[Qiang(Joe) Xu, 2017-06-22 22:56:29]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-06-22 22:57:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 23:35:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498172189283590,
"parent_rev": "f4d431c396f62c9c205ae13b18c5e17d55fd08f3", "commit_rev":
"1948539699b040fc84719d100788d393260efe95"}

[commit-bot: I haz the power, 2017-06-22 23:35:27]

Description was changed from

==========
cros: update app list item view for all apps grid view

Changes:
(1) app list item view, which is used for all apps grid view, has the
same tile layout (icon, title, and their paddings) requirement as start
page recommended apps tile.
(2) fix recommended apps tile title width issue: it has 80px width
requirement, we just need to set left and right 8px insets for it.

R=xiyuan@chromium.org
CC=newcomer@chromium.org, weidongg@chromium.org
BUG=735702
TEST=tested with and without --enable-features=EnableFullscreenAppList
flag
==========

to

==========
cros: update app list item view for all apps grid view

Changes:
(1) app list item view, which is used for all apps grid view, has the
same tile layout (icon, title, and their paddings) requirement as start
page recommended apps tile.
(2) fix recommended apps tile title width issue: it has 80px width
requirement, we just need to set left and right 8px insets for it.

R=xiyuan@chromium.org
CC=newcomer@chromium.org, weidongg@chromium.org
BUG=735702
TEST=tested with and without --enable-features=EnableFullscreenAppList
flag

Review-Url: https://codereview.chromium.org/2945343003
Cr-Commit-Position: refs/heads/master@{#481720}
Committed:
https://chromium.googlesource.com/chromium/src/+/1948539699b040fc84719d100788...
==========

[commit-bot: I haz the power, 2017-06-22 23:35:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1948539699b040fc84719d100788...