Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2945303002: [Payments] Update country codes in phone number validator and formatter for editing profile (Closed)

Created:
3 years, 6 months ago by gogerald1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, agrieve+watch_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update country codes in phone number validator and formatter for editing profile This CL also fixes the bug in this CL https://codereview.chromium.org/2952673002/ to add phone number suggestions. BUG=723769 Review-Url: https://codereview.chromium.org/2945303002 Cr-Commit-Position: refs/heads/master@{#481223} Committed: https://chromium.googlesource.com/chromium/src/+/b01dc5448d235367e67b6bc4c1e58aa54172fa97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
gogerald1
Hi rouslan@, ptal,
3 years, 6 months ago (2017-06-21 15:45:09 UTC) #6
please use gerrit instead
lgtm
3 years, 6 months ago (2017-06-21 15:46:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945303002/1
3 years, 6 months ago (2017-06-21 15:58:17 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 16:52:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b01dc5448d235367e67b6bc4c1e5...

Powered by Google App Engine
This is Rietveld 408576698