Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2945243002: Permissions: Allow PermissionManager to return more PermissionStatusSources.

Created:
3 years, 6 months ago by Patti Lor
Modified:
3 years, 6 months ago
Reviewers:
raymes
CC:
chromium-reviews, awdf+watch_chromium.org, toyoshim+midi_chromium.org, Peter Beverloo, chfremer+watch_chromium.org, mlamouri+watch-notifications_chromium.org, jam, raymes+watch_chromium.org, feature-media-reviews_chromium.org, mlamouri+watch-permissions_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Permissions: Allow PermissionManager to return more PermissionStatusSources. Currently, calls to PermissionManager::GetPermissionStatus() will return a setting and a PermissionStatusSource enum value to describe the source of the setting. However, the PermissionStatusSource enum doesn't contain entries for all the possible sources, primarily "enterprise policy" and "extensions", which are both able to control the value of an origin's content setting. (Also see SettingSource, which describes the possible content setting sources for non-permissions as well.) Add entries to PermissionStatusSource to show these sources, as well as permissions blocked due to "insecure origin", and do some plumbing to surface them in PermissionManager. This is needed in order to show the user what has control over their content settings in future UI found in Chrome Settings ("Site Details"). BUG=656758

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix a bunch of compilation errors. #

Patch Set 4 : Fix flash and avoid referencing extensions code on Android. #

Patch Set 5 : Prevent Windows from linking to the same TesterForType created in host_content_settings_map_unittes… #

Patch Set 6 : Friend test to fix compile error. #

Patch Set 7 : Write PermissionManagerStatusSourceTest.Extension and fix SourceOverriddenByOtherSource. #

Patch Set 8 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -104 lines) Patch
M chrome/browser/geolocation/geolocation_permission_context_android.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_android.cc View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/media/midi_permission_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/midi_permission_context.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context.cc View 1 2 2 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_device_permission_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc/media_stream_device_permission_context.cc View 1 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/notifications/notification_permission_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_permission_context.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_context_base.cc View 1 2 3 4 5 6 7 6 chunks +29 lines, -19 lines 0 comments Download
M chrome/browser/permissions/permission_manager_unittest.cc View 1 2 3 4 5 6 7 5 chunks +295 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/permissions/permission_result.h View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_uma_util.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_util.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_util.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/plugins/flash_download_interception.cc View 1 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/plugins/flash_permission_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/flash_permission_context.cc View 1 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 2 3 4 chunks +30 lines, -20 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_utils.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_utils.cc View 5 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 35 (34 generated)
Patti Lor
3 years, 6 months ago (2017-06-26 03:11:52 UTC) #33
Hey Raymes, PTAL? Most changes are pretty mechanical, see tests in
permission_manager_unittest.cc.

Powered by Google App Engine
This is Rietveld 408576698