Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 294523007: Fix kType narrowing conversion in the `{}` (Closed)

Created:
6 years, 7 months ago by yusukesuzuki
Modified:
6 years, 7 months ago
Reviewers:
Johnny, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix kType narrowing conversion in the `{}` Since narrowing conversion in the `{}` is ill-formed in C++11, it raises compile error with G++ 4.8.2. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/spdy/spdy_framer_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yusukesuzuki
PTAL
6 years, 7 months ago (2014-05-19 09:38:25 UTC) #1
Ryan Hamilton
jgraettinger: can you take a look, since this change might need to be merged...
6 years, 7 months ago (2014-05-19 14:44:09 UTC) #2
Johnny
lgtm. Ryan will need to stamp.
6 years, 7 months ago (2014-05-19 16:03:27 UTC) #3
Ryan Hamilton
lgtm
6 years, 7 months ago (2014-05-19 16:08:41 UTC) #4
yusukesuzuki
The CQ bit was checked by yusukesuzuki@chromium.org
6 years, 7 months ago (2014-05-19 16:31:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukesuzuki@chromium.org/294523007/1
6 years, 7 months ago (2014-05-19 16:32:50 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 18:17:19 UTC) #7
Message was sent while issue was closed.
Change committed as 271427

Powered by Google App Engine
This is Rietveld 408576698