Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: net/spdy/spdy_framer_test.cc

Issue 294523007: Fix kType narrowing conversion in the `{}` (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_framer_test.cc
diff --git a/net/spdy/spdy_framer_test.cc b/net/spdy/spdy_framer_test.cc
index dfb1f9fa89c91857d25433a1d196d1135098cddf..78cb0cd8064abf2fd575333b6dfd7f2a96af0949 100644
--- a/net/spdy/spdy_framer_test.cc
+++ b/net/spdy/spdy_framer_test.cc
@@ -2912,7 +2912,7 @@ TEST_P(SpdyFramerTest, SerializeBlocked) {
SpdyFramer framer(spdy_version_);
const char kDescription[] = "BLOCKED frame";
- const char kType = static_cast<unsigned char>(
+ const unsigned char kType = static_cast<unsigned char>(
SpdyConstants::SerializeFrameType(spdy_version_, BLOCKED));
const unsigned char kFrameData[] = {
0x00, 0x00, kType, 0x00,
@@ -2978,7 +2978,7 @@ TEST_P(SpdyFramerTest, CreateAltSvc) {
SpdyFramer framer(spdy_version_);
const char kDescription[] = "ALTSVC frame";
- const char kType = static_cast<unsigned char>(
+ const unsigned char kType = static_cast<unsigned char>(
SpdyConstants::SerializeFrameType(spdy_version_, ALTSVC));
const unsigned char kFrameData[] = {
0x00, 0x17, kType, 0x00,
@@ -5224,7 +5224,7 @@ TEST_P(SpdyFramerTest, OnAltSvcBadLengths) {
return;
}
- const char kType = static_cast<unsigned char>(
+ const unsigned char kType = static_cast<unsigned char>(
SpdyConstants::SerializeFrameType(spdy_version_, ALTSVC));
{
TestSpdyVisitor visitor(spdy_version_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698