Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp

Issue 2945223002: Add deprecation warnings for permission API usage from iframes (Closed)
Patch Set: Depreaction warnings Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp
diff --git a/third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp b/third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp
index 83ccd58857152abbef42c0e1e316a25ee190f914..afc7fab1e66afe402e0d397742fcbaacbb018f5d 100644
--- a/third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp
+++ b/third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp
@@ -32,9 +32,10 @@
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptPromiseResolver.h"
-#include "core/dom/DOMException.h"
#include "core/dom/Document.h"
iclelland 2017/06/22 15:12:48 Whoa -- when did the strict ASCII ordering change?
raymes 2017/07/05 01:04:26 Fixed :) not sure what happened
+#include "core/dom/DOMException.h"
#include "core/dom/ExecutionContext.h"
+#include "core/frame/Deprecation.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/Navigator.h"
#include "core/frame/UseCounter.h"
@@ -87,6 +88,9 @@ ScriptPromise NavigatorWebMIDI::requestMIDIAccess(ScriptState* script_state,
}
UseCounter::CountCrossOriginIframe(document,
WebFeature::kRequestMIDIAccessIframe);
+ Deprecation::CountDeprecationCrossOriginIframe(
+ document, WebFeature::kRequestMIDIAccessDisabledIframe);
+
return MIDIAccessInitializer::Start(script_state, options);
}

Powered by Google App Engine
This is Rietveld 408576698