third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp - Issue 2945223002: Add deprecation warnings for permission API usage from iframes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

Issue 2945223002: Add deprecation warnings for permission API usage from iframes (Closed)

Patch Set: Depreaction warnings Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

index a69f4f25438bd9582e231b4d5fa52f0f40c5ee5b..6b17e9635760b7c06e28ba5b8bbee4c05bc0aad5 100644

--- a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

@@ -402,6 +402,8 @@ bool UserMediaRequest::IsSecureContextUse(String& error_message) {

WebFeature::kGetUserMediaSecureOrigin);

UseCounter::CountCrossOriginIframe(

*document, WebFeature::kGetUserMediaSecureOriginIframe);

+ Deprecation::CountDeprecationCrossOriginIframe(

+ *document, WebFeature::kGetUserMediaDisabledIframe);

HostsUsingFeatures::CountAnyWorld(

*document, HostsUsingFeatures::Feature::kGetUserMediaSecureHost);

return true;