third_party/WebKit/Source/modules/geolocation/Geolocation.cpp - Issue 2945223002: Add deprecation warnings for permission API usage from iframes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2945223002: Add deprecation warnings for permission API usage from iframes (Closed)

Patch Set: Depreaction warnings Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

index a49fea97e47e7b1d2af3f2810f96ceae80bccffd..0251c1c91c94d6d847e9bc0a1c8da2178960b9ba 100644

--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

@@ -151,6 +151,8 @@ void Geolocation::RecordOriginTypeAccess() const {

UseCounter::Count(document, WebFeature::kGeolocationSecureOrigin);

UseCounter::CountCrossOriginIframe(

*document, WebFeature::kGeolocationSecureOriginIframe);

+ Deprecation::CountDeprecationCrossOriginIframe(

+ *document, WebFeature::kGeolocationDisabledIframe);

} else if (GetFrame()

->GetSettings()

->GetAllowGeolocationOnInsecureOrigins()) {