Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2945193002:
Replace all instances of 'Website Settings popup' with 'Page Info popup.' (Closed)
DescriptionReplace all instances of 'Website Settings popup' with 'Page Info popup.'
BUG=716300
Review-Url: https://codereview.chromium.org/2945193002
Cr-Commit-Position: refs/heads/master@{#481565}
Committed: https://chromium.googlesource.com/chromium/src/+/36adb726c5dc4a04d5064b6dca82f78f29aad6e9
Patch Set 1 #
Total comments: 2
Patch Set 2 : Replace all instances of 'Website Settings popup' with 'Page Info popup'. #
Messages
Total messages: 35 (20 generated)
Description was changed from ========== Replaced all instances of 'Website Settings popup' with 'Page Info popup.' BUG= ========== to ========== Replaced all instances of 'Website Settings popup' with 'Page Info popup.' BUG=716300 ==========
sperigo@chromium.org changed reviewers: + lgarron@chromium.org, meacer@chromium.org
:)
LGTM; thanks!
The CQ bit was checked by sperigo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: The author sperigo@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was checked by sperigo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
The author sperigo@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
Can you also change "Replaced" to "Replace" in the commit message? Not a big deal, but it'd be consistent with other commit messages. https://codereview.chromium.org/2945193002/diff/1/components/page_info_string... File components/page_info_strings.grdp (right): https://codereview.chromium.org/2945193002/diff/1/components/page_info_string... components/page_info_strings.grdp:64: when using an administrator-provided certificate"> Convert tabs to spaces (if you are using Sublime Text, you might want to set this as default. Instructions: https://chromium.googlesource.com/chromium/src/+/master/docs/linux_sublime_de...)
Description was changed from ========== Replaced all instances of 'Website Settings popup' with 'Page Info popup.' BUG=716300 ========== to ========== Replace all instances of 'Website Settings popup' with 'Page Info popup.' BUG=716300 ==========
The CQ bit was checked by sperigo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Latest patchset lgtm! (You'll want to mark comments as Done and then "Publish+Mail Comments" otherwise reviewers don't get a notification)
The CQ bit was checked by sperigo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lgarron@chromium.org Link to the patchset: https://codereview.chromium.org/2945193002/#ps20001 (title: "Replace all instances of 'Website Settings popup' with 'Page Info popup'.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Resolved comment about spaces vs tabs. :) https://codereview.chromium.org/2945193002/diff/1/components/page_info_string... File components/page_info_strings.grdp (right): https://codereview.chromium.org/2945193002/diff/1/components/page_info_string... components/page_info_strings.grdp:64: when using an administrator-provided certificate"> On 2017/06/21 17:43:34, meacer wrote: > Convert tabs to spaces (if you are using Sublime Text, you might want to set > this as default. Instructions: > https://chromium.googlesource.com/chromium/src/+/master/docs/linux_sublime_de...) Done.
Resolved comment about spaces vs tabs. :)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgarron@chromium.org changed reviewers: + isherman@chromium.org
isherman@, could you review histograms.xml?
histograms.xml lgtm, thanks.
The CQ bit was checked by isherman@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498149942379360,
"parent_rev": "31a6a2d6872b4eec83c2331a39d6cbd4f8b7b4cb", "commit_rev":
"36adb726c5dc4a04d5064b6dca82f78f29aad6e9"}
Message was sent while issue was closed.
Description was changed from ========== Replace all instances of 'Website Settings popup' with 'Page Info popup.' BUG=716300 ========== to ========== Replace all instances of 'Website Settings popup' with 'Page Info popup.' BUG=716300 Review-Url: https://codereview.chromium.org/2945193002 Cr-Commit-Position: refs/heads/master@{#481565} Committed: https://chromium.googlesource.com/chromium/src/+/36adb726c5dc4a04d5064b6dca82... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/36adb726c5dc4a04d5064b6dca82... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
