Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2945173003: Inline CSSParserToken::CSSParserToken (Closed)

Created:
3 years, 6 months ago by hans
Modified:
3 years, 6 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline CSSParserToken::CSSParserToken These functions are hit frequently and we'd like them to be available for inlining even in non-LTO builds (see bug). BUG=728324 Review-Url: https://codereview.chromium.org/2945173003 Cr-Commit-Position: refs/heads/master@{#481124} Committed: https://chromium.googlesource.com/chromium/src/+/a8a293697a89e19a3ac294cf303f18d7e41237d8

Patch Set 1 #

Patch Set 2 : Let's do this one too #

Patch Set 3 : fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSParserToken.h View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
hans
Please take a look.
3 years, 6 months ago (2017-06-21 00:44:02 UTC) #2
hans
Found this second ctor is hit pretty often too.
3 years, 6 months ago (2017-06-21 00:48:19 UTC) #4
Nico
lgtm
3 years, 6 months ago (2017-06-21 00:50:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945173003/20001
3 years, 6 months ago (2017-06-21 00:54:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/293039)
3 years, 6 months ago (2017-06-21 01:30:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945173003/40001
3 years, 6 months ago (2017-06-21 03:57:50 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 06:31:09 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a8a293697a89e19a3ac294cf303f...

Powered by Google App Engine
This is Rietveld 408576698