Fix handling for click that brings lock screen app to foreground

Fix handling for click that brings lock screen app to foreground

Reintroduces document click handler to screen_account_picker which brings
lock screen app window (if one exists) to foreground - this should happen
if the user clicks outside user pod/login header bar.

Removes background dim when an app window is in background - new UI
has the background dimmed by default.

Review-Url: https://codereview.chromium.org/2945153002
Cr-Commit-Position: refs/heads/master@{#481012}
Committed: https://chromium.googlesource.com/chromium/src/+/b90a97ab99ad72ebf16aae5ee56c82b5017544ac

[tbarzic, 2017-06-20 21:00:58]

Description was changed from

==========
Fix handling for click that brings lock screen app to foreground

Reintroduces document click handler to screen_account_picker which brings
lock screen app window (if one exists) to foreground - this should happen
if the user clicks outside user pod/login header bar.
==========

to

==========
Fix handling for click that brings lock screen app to foreground

Reintroduces document click handler to screen_account_picker which brings
lock screen app window (if one exists) to foreground - this should happen
if the user clicks outside user pod/login header bar.

Removes background dim when an app window is in background - new UI
has the background dimmed by default.
==========

[tbarzic, 2017-06-20 21:28:30]

tbarzic@chromium.org changed reviewers:
+ wzang@chromium.org, xiyuan@chromium.org

[tbarzic, 2017-06-20 21:28:32]

xiyuan - for owner approval

[Wenzhao (Colin) Zang, 2017-06-20 21:37:03]

lgtm

[xiyuan, 2017-06-20 21:39:16]

lgtm

https://codereview.chromium.org/2945153002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/md_screen_account_picker.js (right):

https://codereview.chromium.org/2945153002/diff/20001/ui/login/account_picker...
ui/login/account_picker/md_screen_account_picker.js:497: if
(this.lockScreenAppsState_  != LOCK_SCREEN_APPS_STATE.BACKGROUND ||
nit: strip 1 space before "!=" since you are here. :)

[tbarzic, 2017-06-20 22:07:57]

https://codereview.chromium.org/2945153002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/md_screen_account_picker.js (right):

https://codereview.chromium.org/2945153002/diff/20001/ui/login/account_picker...
ui/login/account_picker/md_screen_account_picker.js:497: if
(this.lockScreenAppsState_  != LOCK_SCREEN_APPS_STATE.BACKGROUND ||
On 2017/06/20 21:39:16, xiyuan wrote:
> nit: strip 1 space before "!=" since you are here. :)

Done.

[tbarzic, 2017-06-20 22:08:01]

The CQ bit was checked by tbarzic@chromium.org

[tbarzic, 2017-06-20 22:08:02]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
wzang@chromium.org
Link to the patchset: https://codereview.chromium.org/2945153002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-06-20 22:08:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 23:11:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497996481886470,
"parent_rev": "7c54a077d28ab2547386556e4c23c6714327a49b", "commit_rev":
"5bc3cbb8a18a16f022b5493bcbd45cecfd62c9b5"}

[commit-bot: I haz the power, 2017-06-20 23:11:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497996481886470,
"parent_rev": "e5bfb5b5caf1fd7cdc0e9ea3f9bb0d48ad6d11a4", "commit_rev":
"50a12bc8b59878db68bbe7c13d2dc0a75b98a286"}

[commit-bot: I haz the power, 2017-06-20 23:12:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497996481886470,
"parent_rev": "bd7286d6a9af37769f5761f62f7a102ec46ba1c1", "commit_rev":
"b90a97ab99ad72ebf16aae5ee56c82b5017544ac"}

[commit-bot: I haz the power, 2017-06-20 23:12:14]

Description was changed from

==========
Fix handling for click that brings lock screen app to foreground

Reintroduces document click handler to screen_account_picker which brings
lock screen app window (if one exists) to foreground - this should happen
if the user clicks outside user pod/login header bar.

Removes background dim when an app window is in background - new UI
has the background dimmed by default.
==========

to

==========
Fix handling for click that brings lock screen app to foreground

Reintroduces document click handler to screen_account_picker which brings
lock screen app window (if one exists) to foreground - this should happen
if the user clicks outside user pod/login header bar.

Removes background dim when an app window is in background - new UI
has the background dimmed by default.

Review-Url: https://codereview.chromium.org/2945153002
Cr-Commit-Position: refs/heads/master@{#481012}
Committed:
https://chromium.googlesource.com/chromium/src/+/b90a97ab99ad72ebf16aae5ee56c...
==========

[commit-bot: I haz the power, 2017-06-20 23:12:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b90a97ab99ad72ebf16aae5ee56c...