Page info UI icons updated for Ads.

Page info UI icons updated for Ads.
Screenshots updated in comment #48 in the associated bug.

BUG=689992
Review-Url: https://codereview.chromium.org/2945113004
Cr-Commit-Position: refs/heads/master@{#481456}
Committed: https://chromium.googlesource.com/chromium/src/+/0f85fb2fc13f1d0e20dafd60f454725ef09d8635

[shivanisha, 2017-06-21 23:11:35]

The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 23:11:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shivanisha, 2017-06-21 23:15:03]

shivanisha@chromium.org changed reviewers:
+ thestig@chromium.org

[shivanisha, 2017-06-21 23:15:26]

Description was changed from

==========
Page info UI icons updated for Ads.

BUG=689992
==========

to

==========
Page info UI icons updated for Ads.
Screenshots updated in comment #48 in the associated bug.

BUG=689992
==========

[shivanisha, 2017-06-21 23:16:12]

thestig@, PTAL, Thanks!

[Lei Zhang, 2017-06-21 23:31:14]

thestig@chromium.org changed reviewers:
+ lgarron@chromium.org

[Lei Zhang, 2017-06-21 23:31:15]

+lgarron since I'm not familiar with the details of this feature.

[lgarron, 2017-06-21 23:37:23]

This part looks good.

Could you also match the CONTENT_SETTINGS_TYPE_ADS rename by doing the following
in this CL?
- rename the files to {allowed,blocked}_ads.png
- rename IDR_{ALLOWED,BLOCKED}_SUBRESOURCE_FILTER to IDR_{BLOCKED,ALLOWED}_ADS
everywhere

[commit-bot: I haz the power, 2017-06-22 00:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 00:15:24]

Dry run: This issue passed the CQ dry run.

[shivanisha, 2017-06-22 01:15:10]

The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 01:15:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shivanisha, 2017-06-22 01:20:10]

Feedback addressed. PTAL, Thanks!

[commit-bot: I haz the power, 2017-06-22 02:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 02:36:54]

Dry run: This issue passed the CQ dry run.

[chromium-reviews, 2017-06-22 05:18:35]

LGTM
On Wed, Jun 21, 2017 at 18:20 <shivanisha@chromium.org> wrote:

> Feedback addressed. PTAL, Thanks!
>
> https://codereview.chromium.org/2945113004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[lgarron, 2017-06-22 05:19:46]

LGTM

(This time from the right address. *shakes hand at GMail heuristics*)

On Wed, Jun 21, 2017 at 18:20 <shivanisha@chromium.org> wrote:

> Feedback addressed. PTAL, Thanks!
>
> https://codereview.chromium.org/2945113004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[shivanisha, 2017-06-22 05:21:27]

On 2017/06/22 at 05:19:46, lgarron wrote:
> LGTM
> 
> (This time from the right address. *shakes hand at GMail heuristics*)
> 
> On Wed, Jun 21, 2017 at 18:20 <shivanisha@chromium.org> wrote:
> 
> > Feedback addressed. PTAL, Thanks!
> >
> > https://codereview.chromium.org/2945113004/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to chromium-reviews+unsubscribe@chromium.org.
> 

It still doesn't show your name as green. I wonder why?

[Use Chromium address instead., 2017-06-22 05:21:39]

I would if the UI weren't broken and WontFix-ed, my dear bot. ;-)
On Wed, Jun 21, 2017 at 22:19 <reply@chromiumcodereview-hr.appspotmail.com>
wrote:

>
> REMINDER: If this change looks good, please use the LGTM button at
> https://codereview.chromium.org/2945113004/publish
>

[chromium-reviews, 2017-06-22 05:22:37]

Because Rietveld is broken on iOS and replying from email apparently
doesn't work. I'll approve tomorrow when I'm at work.
On Wed, Jun 21, 2017 at 22:21 <shivanisha@chromium.org> wrote:

> On 2017/06/22 at 05:19:46, lgarron wrote:
> > LGTM
> >
> > (This time from the right address. *shakes hand at GMail heuristics*)
> >
> > On Wed, Jun 21, 2017 at 18:20 <shivanisha@chromium.org&gt; wrote:
> >
> > > Feedback addressed. PTAL, Thanks!
> > >
> > > https://codereview.chromium.org/2945113004/
> > >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
> >
>
> It still doesn't show your name as green. I wonder why?
>
> https://codereview.chromium.org/2945113004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[shivanisha, 2017-06-22 05:30:07]

On 2017/06/22 at 05:22:37, chromium-reviews wrote:
> Because Rietveld is broken on iOS and replying from email apparently
> doesn't work. I'll approve tomorrow when I'm at work.
> On Wed, Jun 21, 2017 at 22:21 <shivanisha@chromium.org> wrote:
> 
> > On 2017/06/22 at 05:19:46, lgarron wrote:
> > > LGTM
> > >
> > > (This time from the right address. *shakes hand at GMail heuristics*)
> > >
> > > On Wed, Jun 21, 2017 at 18:20 <shivanisha@chromium.org&gt; wrote:
> > >
> > > > Feedback addressed. PTAL, Thanks!
> > > >
> > > > https://codereview.chromium.org/2945113004/
> > > >
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an
> > email to chromium-reviews+unsubscribe@chromium.org.
> > >
> >
> > It still doesn't show your name as green. I wonder why?
> >
> > https://codereview.chromium.org/2945113004/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to chromium-reviews+unsubscribe@chromium.org.
> 

thestig@, PTAL for owner's approval. 
(lgarron@ has almost lgtm'ed except there is a technical issue using the code
review tool from ios (see message above)).

[Lei Zhang, 2017-06-22 05:34:30]

Description was changed from

==========
Page info UI icons updated for Ads.
Screenshots updated in comment #48 in the associated bug.

BUG=689992
==========

to

==========
Page info UI icons updated for Ads.
Screenshots updated in comment #48 in the associated bug.

BUG=689992
==========

[Lei Zhang, 2017-06-22 05:34:31]

thestig@chromium.org changed reviewers:
- lgarron@google.com

[Lei Zhang, 2017-06-22 05:43:53]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2017-06-22 05:43:54]

lgtm

[commit-bot: I haz the power, 2017-06-22 05:44:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 05:48:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498110233398910,
"parent_rev": "c736555ad42dd36b986506e05bc532529bf5f808", "commit_rev":
"0f85fb2fc13f1d0e20dafd60f454725ef09d8635"}

[commit-bot: I haz the power, 2017-06-22 05:48:25]

Description was changed from

==========
Page info UI icons updated for Ads.
Screenshots updated in comment #48 in the associated bug.

BUG=689992
==========

to

==========
Page info UI icons updated for Ads.
Screenshots updated in comment #48 in the associated bug.

BUG=689992

Review-Url: https://codereview.chromium.org/2945113004
Cr-Commit-Position: refs/heads/master@{#481456}
Committed:
https://chromium.googlesource.com/chromium/src/+/0f85fb2fc13f1d0e20dafd60f454...
==========

[commit-bot: I haz the power, 2017-06-22 05:48:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0f85fb2fc13f1d0e20dafd60f454...

[lgarron, 2017-06-22 07:50:19]

lgtm