Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2945103002: Don't process text changes when ChromeVox range is elsewhere (Closed)

Created:
3 years, 6 months ago by David Tseng
Modified:
3 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, aleventhal+watch_chromium.org, je_julie, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't process text changes when ChromeVox range is elsewhere BUG=734816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2945103002 Cr-Commit-Position: refs/heads/master@{#481239} Committed: https://chromium.googlesource.com/chromium/src/+/ac87a1f26b6c2dbf65e11cf9da3ef203763fd87f

Patch Set 1 #

Patch Set 2 : Re-target node for text handler creation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
David Tseng
3 years, 6 months ago (2017-06-20 18:20:27 UTC) #4
dmazzoni
lgtm
3 years, 6 months ago (2017-06-21 05:56:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945103002/20001
3 years, 6 months ago (2017-06-21 17:42:23 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 17:48:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ac87a1f26b6c2dbf65e11cf9da3e...

Powered by Google App Engine
This is Rietveld 408576698