chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc - Issue 2945023002: Introduce profile for lock screen apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

Issue 2945023002: Introduce profile for lock screen apps (Closed)

Patch Set: . Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc ('K') | « chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc ('k') | chrome/browser/chromeos/profiles/profile_helper.h » ('j') | chrome/browser/chromeos/profiles/profile_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

diff --git a/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc b/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

index b0681d7a3dc7629e239e8e25f5cdabd5959ed78c..37b53c4362cf7546ef78ce2a5bc09015862a2020 100644

--- a/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

+++ b/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

@@ -147,8 +147,10 @@ UserPolicyManagerFactoryChromeOS::CreateManagerForProfile(

const base::CommandLine* command_line =

base::CommandLine::ForCurrentProcess();

// Don't initialize cloud policy for the signin profile.

emaxx 2017/06/23 16:16:30 nit: Add " and the lock screen app profile".

tbarzic 2017/06/23 17:18:40 Done.

- if (chromeos::ProfileHelper::IsSigninProfile(profile))

+ if (chromeos::ProfileHelper::IsSigninProfile(profile) ||

+ chromeos::ProfileHelper::IsLockScreenAppProfile(profile)) {

return {};

+ }

// |user| should never be nullptr except for the signin profile. This object

emaxx 2017/06/23 16:16:30 nit: Update this comment too.

tbarzic 2017/06/23 17:18:40 Done.

// is created as part of the Profile creation, which happens right after