grpc: Interceptor to catch panics and convert them to Internal errors.

grpc: Interceptor to catch panics and convert them to Internal errors.

Also make sure monitoring interceptor doesn't report panics as codes.OK.

R=iannucci@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2945013002
Committed: https://github.com/luci/luci-go/commit/985d9cf9b317c12615370ca4ebdebe44d3658a81

[Vadim Sh., 2017-06-20 04:30:13]

PTAL

https://codereview.chromium.org/2945013002/diff/20001/grpc/grpcmon/server.go
File grpc/grpcmon/server.go (right):

https://codereview.chromium.org/2945013002/diff/20001/grpc/grpcmon/server.go#...
grpc/grpcmon/server.go:58: code = codes.Internal
I think it used to log it as codes.OK because it saw err is nil.

While using dedicated panic catching interceptor is better, I think correctly
handling panics here is also important.

[iannucci, 2017-06-20 22:40:33]

lgtm

[Vadim Sh., 2017-06-20 22:43:53]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2017-06-20 22:43:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 22:57:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497998633669990,
"parent_rev": "e472357afe0b83c90c44004977799450e16966b9", "commit_rev":
"985d9cf9b317c12615370ca4ebdebe44d3658a81"}

[commit-bot: I haz the power, 2017-06-20 22:58:00]

Description was changed from

==========
grpc: Interceptor to catch panics and convert them to Internal errors.

Also make sure monitoring interceptor doesn't report panics as codes.OK.

R=iannucci@chromium.org
BUG=
==========

to

==========
grpc: Interceptor to catch panics and convert them to Internal errors.

Also make sure monitoring interceptor doesn't report panics as codes.OK.

R=iannucci@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2945013002
Committed:
https://github.com/luci/luci-go/commit/985d9cf9b317c12615370ca4ebdebe44d3658a81
==========

[commit-bot: I haz the power, 2017-06-20 22:58:00]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/985d9cf9b317c12615370ca4ebdebe44d3658a81