Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2945002: Disk cache: Switch the disk cache to use the cache_thread.... (Closed)

Created:
10 years, 5 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, John Grabowski, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disk cache: Switch the disk cache to use the cache_thread. Add an InFlightBackendIO class that handles posting of cacheoperations back and forth between the IO thread and the cachethread. BUG=26730 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52185

Patch Set 1 #

Patch Set 2 : ...and another change #

Patch Set 3 : Fix for valgrind runs #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1418 lines, -873 lines) Patch
M net/disk_cache/backend_impl.h View 10 chunks +40 lines, -9 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 1 2 3 17 chunks +238 lines, -94 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 13 chunks +80 lines, -17 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.h View 4 chunks +7 lines, -1 line 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 5 chunks +26 lines, -7 lines 0 comments Download
M net/disk_cache/entry_impl.h View 2 chunks +15 lines, -2 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 1 14 chunks +124 lines, -44 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 1 2 11 chunks +40 lines, -30 lines 0 comments Download
M net/disk_cache/eviction.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/file_posix.cc View 4 chunks +11 lines, -2 lines 0 comments Download
A net/disk_cache/in_flight_backend_io.h View 1 chunk +200 lines, -0 lines 0 comments Download
A net/disk_cache/in_flight_backend_io.cc View 1 1 chunk +448 lines, -0 lines 0 comments Download
A + net/disk_cache/in_flight_io.h View 4 chunks +56 lines, -301 lines 0 comments Download
A + net/disk_cache/in_flight_io.cc View 2 chunks +27 lines, -333 lines 0 comments Download
M net/disk_cache/sparse_control.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M net/disk_cache/stress_cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_cache_unittest.cc View 3 chunks +31 lines, -3 lines 0 comments Download
M net/net.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/crash_cache/crash_cache.cc View 12 chunks +25 lines, -5 lines 0 comments Download
M net/tools/dump_cache/upgrade.cc View 6 chunks +33 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rvargas (doing something else)
And here we go again... as usual, the first set is what I checked in ...
10 years, 5 months ago (2010-07-09 03:13:10 UTC) #1
nsylvain
LGTM
10 years, 5 months ago (2010-07-12 21:34:47 UTC) #2
gavinp
10 years, 5 months ago (2010-07-13 12:31:40 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698