Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2944973002: Remove IS_IOS checks in chrome/ (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
CC:
chromium-reviews, lgarron+watch_chromium.org, asvitkine+watch_chromium.org, imcheng+watch_chromium.org, avayvod+watch_chromium.org, raymes+watch_chromium.org, browser-components-watch_chromium.org, timvolodine, miu+watch_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, apacible+watch_chromium.org, jasonroberts+watch_google.com, groby+spellwatch_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, dtrainor+watch_chromium.org, isheriff+watch_chromium.org, mac-reviews_chromium.org, erickung+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IS_IOS checks in chrome/ The directory is not used on iOS at all. Review-Url: https://codereview.chromium.org/2944973002 Cr-Commit-Position: refs/heads/master@{#480991} Committed: https://chromium.googlesource.com/chromium/src/+/0c55ee38040de7ca13ccf95fb1c29a0227416974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -61 lines) Patch
M chrome/browser/about_flags.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_commands.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/favicon/content_favicon_driver_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/flag_descriptions.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/cast_remoting_connector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tracing/background_tracing_field_trial.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_ui_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/page_info/page_info.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/page_info/page_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_export_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_features.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_features.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_paths_mac.mm View 6 chunks +0 lines, -14 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
3 years, 6 months ago (2017-06-20 18:22:46 UTC) #6
Eugene But (OOO till 7-30)
lgtm
3 years, 6 months ago (2017-06-20 21:56:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944973002/1
3 years, 6 months ago (2017-06-20 22:09:31 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 22:18:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c55ee38040de7ca13ccf95fb1c2...

Powered by Google App Engine
This is Rietveld 408576698