Add effective-expiration-date to Expect-CT reports

Add effective-expiration-date to Expect-CT reports

This CL sends the Expect-CT expiration into the reporter, to include in the
report as key "effective-expiration-date".

http://httpwg.org/http-extensions/expect-ct.html#rfc.section.3.1

BUG=679012
Review-Url: https://codereview.chromium.org/2944953002
Cr-Commit-Position: refs/heads/master@{#481022}
Committed: https://chromium.googlesource.com/chromium/src/+/ae028b467bda4a4adcc64de62d47d44ff3920524

[estark, 2017-06-20 00:19:50]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 00:20:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-06-20 00:20:58]

estark@chromium.org changed reviewers:
+ mattm@chromium.org, meacer@chromium.org

[estark, 2017-06-20 00:20:59]

mattm: please review net/
meacer: please review chrome/browser/ssl
Thanks!

[meacer, 2017-06-20 00:28:10]

chrome/browser/ssl lgtm

https://codereview.chromium.org/2944953002/diff/1/chrome/browser/ssl/chrome_e...
File chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc (right):

https://codereview.chromium.org/2944953002/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:239: const std::string
expiration_time,
nit: expiration_date to be consistent with the field name (or maybe just
expiration, or expected_expiration)

https://codereview.chromium.org/2944953002/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:439:
base::Time::FromUTCExploded({2017, 1, 0, 1, 0, 0, 0, 0}, &expiration));
nit: Perhaps move this to around line 500 so that it's close to where it's used?

[mattm, 2017-06-20 01:37:25]

net lgtm

[commit-bot: I haz the power, 2017-06-20 02:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 02:28:58]

Dry run: This issue passed the CQ dry run.

[estark, 2017-06-20 21:45:01]

https://codereview.chromium.org/2944953002/diff/1/chrome/browser/ssl/chrome_e...
File chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc (right):

https://codereview.chromium.org/2944953002/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:239: const std::string
expiration_time,
On 2017/06/20 00:28:10, meacer wrote:
> nit: expiration_date to be consistent with the field name (or maybe just
> expiration, or expected_expiration)

Done.

https://codereview.chromium.org/2944953002/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:439:
base::Time::FromUTCExploded({2017, 1, 0, 1, 0, 0, 0, 0}, &expiration));
On 2017/06/20 00:28:10, meacer wrote:
> nit: Perhaps move this to around line 500 so that it's close to where it's
used?

Done.

[estark, 2017-06-20 21:46:26]

The CQ bit was checked by estark@chromium.org

[estark, 2017-06-20 21:46:26]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org,
mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2944953002/#ps20001
(title: "meacer comments")

[commit-bot: I haz the power, 2017-06-20 21:46:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 23:25:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497995186364110,
"parent_rev": "bd6c55e62a7d9723048bb79026cc5ba023fbfd15", "commit_rev":
"ae028b467bda4a4adcc64de62d47d44ff3920524"}

[commit-bot: I haz the power, 2017-06-20 23:25:17]

Description was changed from

==========
Add effective-expiration-date to Expect-CT reports

This CL sends the Expect-CT expiration into the reporter, to include in the
report as key "effective-expiration-date".

http://httpwg.org/http-extensions/expect-ct.html#rfc.section.3.1

BUG=679012
==========

to

==========
Add effective-expiration-date to Expect-CT reports

This CL sends the Expect-CT expiration into the reporter, to include in the
report as key "effective-expiration-date".

http://httpwg.org/http-extensions/expect-ct.html#rfc.section.3.1

BUG=679012

Review-Url: https://codereview.chromium.org/2944953002
Cr-Commit-Position: refs/heads/master@{#481022}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae028b467bda4a4adcc64de62d47...
==========

[commit-bot: I haz the power, 2017-06-20 23:25:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae028b467bda4a4adcc64de62d47...