Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2944923002: VR: Add ellipsis on truncated URLs. (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 6 months ago
Reviewers:
tiborg
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Add ellipsis on truncated URLs. This change switches from pure truncationg to ellipsis-based truncation, but maintains the bail-out mechanism in case we cannot display the complete URL. BUG=728331 Review-Url: https://codereview.chromium.org/2944923002 Cr-Commit-Position: refs/heads/master@{#480828} Committed: https://chromium.googlesource.com/chromium/src/+/02866ac3319203965d739cc479aa329f137d6332

Patch Set 1 #

Patch Set 2 : Comment some non-trivial logic. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 1 1 chunk +11 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
cjgrant
3 years, 6 months ago (2017-06-19 20:15:37 UTC) #2
tiborg
lgtm
3 years, 6 months ago (2017-06-20 14:37:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944923002/20001
3 years, 6 months ago (2017-06-20 14:43:04 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 15:33:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/02866ac3319203965d739cc479aa...

Powered by Google App Engine
This is Rietveld 408576698