Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

Issue 2944873002: Printing: Disable subframes when printing a selection. (Closed)
Patch Set: Fix names conflicts. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
index 070051eb31676dff0198dabcc8dd3e26a74fe7cb..d7c05422e4badffa9c1d9c2ca810776572053d4c 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
@@ -37,9 +37,9 @@ using task_manager::browsertest_util::WaitForTaskManagerRows;
namespace {
-class PrintPreviewBrowserTest : public InProcessBrowserTest {
+class PrintPreviewUiBrowserTest : public InProcessBrowserTest {
Lei Zhang 2017/06/21 07:25:08 Can you name this PrintPreviewUIBrowserTest since
arthursonzogni 2017/06/21 14:01:20 Done.
public:
- PrintPreviewBrowserTest() {}
+ PrintPreviewUiBrowserTest() {}
void Print() {
content::TestNavigationObserver nav_observer(NULL);
@@ -50,7 +50,7 @@ class PrintPreviewBrowserTest : public InProcessBrowserTest {
}
};
-IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest, PrintCommands) {
+IN_PROC_BROWSER_TEST_F(PrintPreviewUiBrowserTest, PrintCommands) {
// We start off at about:blank page.
// Make sure there is 1 tab and print is enabled.
ASSERT_EQ(1, browser()->tab_strip_model()->count());
@@ -93,7 +93,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest, PrintCommands) {
#else
#define MAYBE_TaskManagerNewPrintPreview TaskManagerNewPrintPreview
#endif
-IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest,
+IN_PROC_BROWSER_TEST_F(PrintPreviewUiBrowserTest,
MAYBE_TaskManagerNewPrintPreview) {
chrome::ShowTaskManager(browser()); // Show task manager BEFORE print dialog.
@@ -112,7 +112,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest,
}
// http://crbug/367665.
-IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest,
+IN_PROC_BROWSER_TEST_F(PrintPreviewUiBrowserTest,
DISABLED_TaskManagerExistingPrintPreview) {
// Create the print preview dialog.
Print();
@@ -128,7 +128,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest,
#if defined(OS_WIN)
// http://crbug.com/396360
-IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest,
+IN_PROC_BROWSER_TEST_F(PrintPreviewUiBrowserTest,
DISABLED_NoCrashOnCloseWithOtherTabs) {
// Now print preview.
Print();

Powered by Google App Engine
This is Rietveld 408576698