Printing: Disable subframes when printing a selection.

chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/task_manager/task_manager_browsertest_util.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 19 matching lines @@
 #endif
 
 using task_manager::browsertest_util::MatchAboutBlankTab;
 using task_manager::browsertest_util::MatchAnyPrint;
 using task_manager::browsertest_util::MatchAnyTab;
 using task_manager::browsertest_util::MatchPrint;
 using task_manager::browsertest_util::WaitForTaskManagerRows;
 
 namespace {
 
-class PrintPreviewBrowserTest : public InProcessBrowserTest {
+class PrintPreviewUiBrowserTest : public InProcessBrowserTest {

[Lei Zhang, 2017/06/21 07:25:08]

Can you name this PrintPreviewUIBrowserTest since the class it's associated with
is named PrintPreviewUI?

[arthursonzogni, 2017/06/21 14:01:20]

Done.

  public:
-  PrintPreviewBrowserTest() {}
+  PrintPreviewUiBrowserTest() {}
 
   void Print() {
     content::TestNavigationObserver nav_observer(NULL);
     nav_observer.StartWatchingNewWebContents();
     chrome::ExecuteCommand(browser(), IDC_PRINT);
     nav_observer.Wait();
     nav_observer.StopWatchingNewWebContents();
   }
 };
 
-IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest, PrintCommands) {
+IN_PROC_BROWSER_TEST_F(PrintPreviewUiBrowserTest, PrintCommands) {
   // We start off at about:blank page.
   // Make sure there is 1 tab and print is enabled.
   ASSERT_EQ(1, browser()->tab_strip_model()->count());
 
   ASSERT_TRUE(chrome::IsCommandEnabled(browser(), IDC_PRINT));
 
 #if BUILDFLAG(ENABLE_BASIC_PRINTING) && !defined(OS_CHROMEOS)
   // This is analagous to ENABLE_BASIC_PRINT_DIALOG but helps to verify
   // that it is defined as expected.
   bool is_basic_print_expected = true;
@@ skipping 22 matching lines @@
   ASSERT_EQ(is_basic_print_expected,
             chrome::IsCommandEnabled(browser(), IDC_BASIC_PRINT));
 }
 
 // Disable the test for mac, see http://crbug/367665.
 #if defined(OS_MACOSX) || defined(OS_LINUX)
 #define MAYBE_TaskManagerNewPrintPreview DISABLED_TaskManagerNewPrintPreview
 #else
 #define MAYBE_TaskManagerNewPrintPreview TaskManagerNewPrintPreview
 #endif
-IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest,
+IN_PROC_BROWSER_TEST_F(PrintPreviewUiBrowserTest,
                        MAYBE_TaskManagerNewPrintPreview) {
   chrome::ShowTaskManager(browser());  // Show task manager BEFORE print dialog.
 
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, MatchAnyPrint()));
 
   // Create the print preview dialog.
   Print();
 
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyPrint()));
   ASSERT_NO_FATAL_FAILURE(
       WaitForTaskManagerRows(1, MatchPrint(url::kAboutBlankURL)));
 }
 
 // http://crbug/367665.
-IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest,
+IN_PROC_BROWSER_TEST_F(PrintPreviewUiBrowserTest,
                        DISABLED_TaskManagerExistingPrintPreview) {
   // Create the print preview dialog.
   Print();
 
   chrome::ShowTaskManager(browser());  // Show task manager AFTER print dialog.
 
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyPrint()));
   ASSERT_NO_FATAL_FAILURE(
       WaitForTaskManagerRows(1, MatchPrint(url::kAboutBlankURL)));
 }
 
 #if defined(OS_WIN)
 // http://crbug.com/396360
-IN_PROC_BROWSER_TEST_F(PrintPreviewBrowserTest,
+IN_PROC_BROWSER_TEST_F(PrintPreviewUiBrowserTest,
                        DISABLED_NoCrashOnCloseWithOtherTabs) {
   // Now print preview.
   Print();
 
   ui_test_utils::NavigateToURLWithDisposition(
       browser(), GURL("about:blank"), WindowOpenDisposition::NEW_FOREGROUND_TAB,
       ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
 
   browser()->tab_strip_model()->ActivateTabAt(0, true);
 
   // Navigate main tab to hide print preview.
   ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
 
   browser()->tab_strip_model()->ActivateTabAt(1, true);
 }
 #endif  // defined(OS_WIN)
 
 }  // namespace