Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 2944743002: [i18n] remove i18n_template.js and load_time_data.js from flags (Closed)

Created:
3 years, 6 months ago by dschuyler
Modified:
3 years, 6 months ago
Reviewers:
tommycli
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[i18n] remove i18n_template.js and load_time_data.js from flags This CL removes some js includes that don't appear to be in use any longer. BUG=677338 Review-Url: https://codereview.chromium.org/2944743002 Cr-Commit-Position: refs/heads/master@{#480930} Committed: https://chromium.googlesource.com/chromium/src/+/3ef8b851e96d0b42897db2c9540caedb4afdc6f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M components/flags_ui/resources/apple_flags.html View 2 chunks +0 lines, -2 lines 0 comments Download
M components/flags_ui/resources/flags.html View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
3 years, 6 months ago (2017-06-17 00:57:39 UTC) #4
tommycli
lgtm good to see you are still on this worthwhile (but long) journey
3 years, 6 months ago (2017-06-17 01:35:21 UTC) #5
dschuyler
3 years, 6 months ago (2017-06-19 21:10:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944743002/1
3 years, 6 months ago (2017-06-20 18:43:30 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 20:22:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ef8b851e96d0b42897db2c9540c...

Powered by Google App Engine
This is Rietveld 408576698