symbolize_trace: symbolize in one go on macOS.

symbolize_trace: symbolize in one go on macOS.

Previously the script was calling atos several times, because it was
passing addresses via command line. It turned out that atos spends most
of its runtime parsing target binary, so this CL dumps addresses in a
file and invokes atos once per binary.

BUG=chromium:732629
Review-Url: https://codereview.chromium.org/2944683002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8f9cc5018f428b0a6569520fa7b6449ecfd29467

[DmitrySkiba, 2017-06-16 21:05:12]

Description was changed from

==========
symbolize_trace: symbolize in one go on macOS.
==========

to

==========
symbolize_trace: symbolize in one go on macOS.

Previously the script was calling atos several times, because it was
passing addresses via command line. It turned out that atos spends most
of its runtime parsing target binary, so this CL dumps addresses in a
file and invokes atos once per binary.

BUG=chromium:732629
==========

[DmitrySkiba, 2017-06-16 21:05:12]

dskiba@chromium.org changed reviewers:
+ erikchen@chromium.org, fmeawad@chromium.org

[erikchen, 2017-06-16 22:25:03]

On 2017/06/16 21:05:12, DmitrySkiba wrote:
> mailto:dskiba@chromium.org changed reviewers:
> + mailto:erikchen@chromium.org, mailto:fmeawad@chromium.org

This looks fully functional to me, and given that symbolize_trace is mostly
un-tested anyways, I think this is good to go. Please land this.

lgtm

[fmeawad, 2017-06-19 19:05:10]

lgtm

[DmitrySkiba, 2017-06-19 19:10:14]

The CQ bit was checked by dskiba@chromium.org

[DmitrySkiba, 2017-06-19 19:10:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2944683002/#ps60001
(title: "Fix experimental symbolize_trace too")

[commit-bot: I haz the power, 2017-06-19 19:10:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 19:35:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497899414768700,
"parent_rev": "0445a0dcb44631704aad8aa95e2c7f7f0ffdf32e", "commit_rev":
"8f9cc5018f428b0a6569520fa7b6449ecfd29467"}

[commit-bot: I haz the power, 2017-06-19 19:35:22]

Description was changed from

==========
symbolize_trace: symbolize in one go on macOS.

Previously the script was calling atos several times, because it was
passing addresses via command line. It turned out that atos spends most
of its runtime parsing target binary, so this CL dumps addresses in a
file and invokes atos once per binary.

BUG=chromium:732629
==========

to

==========
symbolize_trace: symbolize in one go on macOS.

Previously the script was calling atos several times, because it was
passing addresses via command line. It turned out that atos spends most
of its runtime parsing target binary, so this CL dumps addresses in a
file and invokes atos once per binary.

BUG=chromium:732629

Review-Url: https://codereview.chromium.org/2944683002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-06-19 19:35:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...