Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2944663002: Turns on new CPAT protocol support by default. (Closed)

Created:
3 years, 6 months ago by dougarnett
Modified:
3 years, 6 months ago
Reviewers:
bengr, megjablon
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Turns on new CPAT protocol support by default. Enables DataReductionProxyDecidesTransform Feature. BUG=701802 Review-Url: https://codereview.chromium.org/2944663002 Cr-Commit-Position: refs/heads/master@{#480907} Committed: https://chromium.googlesource.com/chromium/src/+/90583d6422c0c059b8c25845a49c51046b605fe2

Patch Set 1 #

Patch Set 2 : Disable new CPAT feature for some unittests still testing old path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc View 1 3 chunks +15 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (13 generated)
dougarnett
Maybe try to turn this on early next week.
3 years, 6 months ago (2017-06-16 21:24:11 UTC) #8
megjablon
lgtm, but just wanted to check, we're ok with enabling this by default rather than ...
3 years, 6 months ago (2017-06-19 20:30:46 UTC) #11
dougarnett
Adding Ben wrt all-on vs. doing finch trial to roll out
3 years, 6 months ago (2017-06-19 23:18:34 UTC) #13
dougarnett
On 2017/06/19 20:30:46, megjablon wrote: > lgtm, but just wanted to check, we're ok with ...
3 years, 6 months ago (2017-06-19 23:20:27 UTC) #14
dougarnett
On 2017/06/19 23:20:27, dougarnett wrote: > On 2017/06/19 20:30:46, megjablon wrote: > > lgtm, but ...
3 years, 6 months ago (2017-06-20 18:17:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944663002/20001
3 years, 6 months ago (2017-06-20 18:18:31 UTC) #17
bengr
On 2017/06/19 23:20:27, dougarnett wrote: > On 2017/06/19 20:30:46, megjablon wrote: > > lgtm, but ...
3 years, 6 months ago (2017-06-20 18:19:19 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 19:36:52 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/90583d6422c0c059b8c25845a49c...

Powered by Google App Engine
This is Rietveld 408576698